Revert "Use TEST_TYPE directly as categories for test filtering"#4135
Open
aalabsi-amd wants to merge 1 commit into
Open
Revert "Use TEST_TYPE directly as categories for test filtering"#4135aalabsi-amd wants to merge 1 commit into
aalabsi-amd wants to merge 1 commit into
Conversation
This reverts commit 0fddcf7.
ScottTodd
reviewed
Mar 24, 2026
Comment on lines
-225
to
-231
| if category not in VALID_TEST_CATEGORIES: | ||
| print( | ||
| f"ERROR: Invalid TEST_TYPE '{TEST_TYPE}'. " | ||
| f"Must be one of: {', '.join(sorted(VALID_TEST_CATEGORIES))}. " | ||
| f"Falling back to 'quick'.", | ||
| file=sys.stderr, | ||
| ) |
Member
There was a problem hiding this comment.
I also came across this code yesterday. This should not have been merged as-is. This should have raised an exception instead of silently falling back to "quick" (stderr does not count if no one is checking it)
See the style guide: https://github.com/ROCm/TheRock/blob/main/docs/development/style_guides/python_style_guide.md#fail-fast-behavior
Member
There was a problem hiding this comment.
(then we could also have a unit test checking that only valid test categories are used, so we don't need to wait until late in the CI pipeline to see issues)
geomin12
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4008
This caused issues in miopen CI running the unintended
fullcategory instead of thestandard.CI is blocking PRs now, need to unblock until we address this change from miopen.