Cherry-pick 2 amd-llvm reverts for performance regressions#4013
Merged
Conversation
Contributor
Author
|
please review, we wish to land this sometime wednesday. |
Contributor
|
@ronlieb, @searlmc1, @kzhuravl, think adding something like this to the gh PR description for our submodule updates would be useful, or just noise? I know this one is out of date after we rebase this PR (or do we still even need this PR after #3834?), but just using it as an example Branch base date: 2026-02-17 Submodule updates
llvm-project changes (5708 commits)AMDGPU-specific:
Compiler infrastructure:
hipify changes (1 commit)
spirv-llvm-translator changes (24 commits)
Cherry-picked commits (after branch base date)
Patches removed (now upstreamed)
|
marbre
reviewed
Mar 18, 2026
Member
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
There is a merge conflict that needs to be resolved first.
Contributor
Author
|
this looks awesome, thanks. hoping we land this one today |
Member
We can't without resolving the conflict first :( |
Contributor
Author
Ack |
lamb-j
force-pushed
the
amd/dev/rlieberm/SMPbumpWW06-7.13-2prs
branch
from
6a154ff to
4f92953
Compare
amd-llvm: 376decc81 -> 910937524 Cherry-picked commits: 1. Revert AMDGPU runtime unrolling fix for cascaded GEPs (#183641) Addresses llama.cpp performance regression 2. Revert SLP vectorizer external uses estimation (fc648683cd75) Reverts tree throttling estimation changes Co-Authored-By: Claude <noreply@anthropic.com>
lamb-j
force-pushed
the
amd/dev/rlieberm/SMPbumpWW06-7.13-2prs
branch
from
4f92953 to
ac68de6
Compare
lamb-j
changed the title
lamb-j
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiler Submodule Update
Cherry-picks 2 revert commits from amd-llvm to address performance regressions.
Submodule Changes
Cherry-picked Commits