-
Notifications
You must be signed in to change notification settings - Fork 245
Add native Linux package building to CI without S3 upload #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
58a3e13
4c8edbf
20617a8
efe7f32
a3fe208
70d5e6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -218,3 +218,36 @@ jobs: | |
| permissions: | ||
| contents: read | ||
| id-token: write | ||
|
|
||
| build_native_linux_packages: | ||
| needs: [build_portable_linux_artifacts] | ||
|
Comment on lines
+222
to
+223
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be moved up in the workflow. Sort by dependency ordering, ROCm core first, then frameworks:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @ScottTodd for the feedback. This is exactly the plan for native packaging. |
||
| name: Build Native Packages (${{ matrix.package_type }}) | ||
| # Build native packages for CI validation without uploading to S3. | ||
| # Run if: | ||
| # - Build succeeded (or using prebuilt artifacts) | ||
| # - Not expecting failure | ||
| if: >- | ||
| ${{ | ||
| !failure() && | ||
| !cancelled() && | ||
| ( | ||
| inputs.use_prebuilt_artifacts == 'false' || | ||
| inputs.use_prebuilt_artifacts == 'true' | ||
|
raramakr marked this conversation as resolved.
|
||
| ) && | ||
| inputs.expect_failure == false | ||
| }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| package_type: [deb, rpm] | ||
| uses: ./.github/workflows/build_native_linux_packages.yml | ||
|
raramakr marked this conversation as resolved.
|
||
| with: | ||
| artifact_group: ${{ inputs.artifact_group }} | ||
| artifact_run_id: ${{ inputs.artifact_run_id != '' && inputs.artifact_run_id || github.run_id }} | ||
| rocm_version: ${{ inputs.rocm_package_version }} | ||
| native_package_type: ${{ matrix.package_type }} | ||
| package_suffix: ${{ inputs.build_variant_suffix }} | ||
| skip_package_upload: true | ||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow is deprecated. Please no new feature work here. Needs to go in https://github.com/ROCm/TheRock/blob/main/.github/workflows/multi_arch_ci_linux.yml instead/also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just switched the default pipeline from ci.yml to multi_arch_ci.yml today with #4204. This workflow now only runs on postsubmit or opt-in on PRs with the
ci:run-non-multi-archlabel.Docs: https://github.com/ROCm/TheRock/blob/main/docs/development/ci_behavior_manipulation.md#pull-request