[ci] Expanding test filter options via PR label selection#3992
Merged
Conversation
…Cm/TheRock into users/geomin12/extended-label
amd-justchen
approved these changes
Mar 16, 2026
Contributor
amd-justchen
left a comment
amd-justchen
left a comment
There was a problem hiding this comment.
LGTM assuming CI passes! Nice unit test.
ScottTodd
added a commit
to ScottTodd/TheRock
that referenced
this pull request
Mar 16, 2026
Add test_type determination to decide_jobs: quick (default), comprehensive (schedule), full (submodule changes or test labels), with test_filter: PR label override. Adopts the test type names from PR ROCm#3992. Extract GitContext dataclass to separate git-derived data from CIInputs. configure() is now fully pure — takes CIInputs + GitContext, no git calls. main() is the only place that builds GitContext.from_repo(). Tests construct GitContext directly. Rename parameters to ci_inputs/git_context throughout for clarity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Landing as case from #3917 is fixed |
dileepr1
pushed a commit
that referenced
this pull request
Mar 17, 2026
ScottTodd
added a commit
to ScottTodd/TheRock
that referenced
this pull request
Mar 18, 2026
Add test_type determination to decide_jobs: quick (default), comprehensive (schedule), full (submodule changes or test labels), with test_filter: PR label override. Adopts the test type names from PR ROCm#3992. Extract GitContext dataclass to separate git-derived data from CIInputs. configure() is now fully pure — takes CIInputs + GitContext, no git calls. main() is the only place that builds GitContext.from_repo(). Tests construct GitContext directly. Rename parameters to ci_inputs/git_context throughout for clarity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dileepr1
added a commit
that referenced
this pull request
Mar 20, 2026
## Motivation #3992 adds support for the test categories for test filtering. Use them directly for selecting the test groups. ## Technical Details Use the new categories - quick, standard, comprehensive and full - from TEST_TYPE variable instead of smoke, nightly etc. ## Test Plan Make sure the tests run as usual Co-authored-by: Dileep Ravindranathan <dileep@dell-rack-13.amd.com>
chiranjeevipattigidi
pushed a commit
that referenced
this pull request
Mar 23, 2026
## Motivation #3992 adds support for the test categories for test filtering. Use them directly for selecting the test groups. ## Technical Details Use the new categories - quick, standard, comprehensive and full - from TEST_TYPE variable instead of smoke, nightly etc. ## Test Plan Make sure the tests run as usual Co-authored-by: Dileep Ravindranathan <dileep@dell-rack-13.amd.com>
ScottTodd
added a commit
to ScottTodd/TheRock
that referenced
this pull request
Mar 23, 2026
Add test_type determination to decide_jobs: quick (default), comprehensive (schedule), full (submodule changes or test labels), with test_filter: PR label override. Adopts the test type names from PR ROCm#3992. Extract GitContext dataclass to separate git-derived data from CIInputs. configure() is now fully pure — takes CIInputs + GitContext, no git calls. main() is the only place that builds GitContext.from_repo(). Tests construct GitContext directly. Rename parameters to ci_inputs/git_context throughout for clarity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to work with test standardization, we are expanding test filters.
Changes:
PR labels for additional tests can be added (i.e. test_filter:nightly)
is_schedule now runs nightly tests
Currently, each component has different filters, so this is a CI update only, and we will update component shards / test filters accordingly once filters are ready per component
Working as test_filter:nightly is properly displayed https://github.com/ROCm/TheRock/actions/runs/22973838135?pr=3917
Fixed post-submit CI issue from #3917 and added unit tests to cover this scenario