Repository navigation
Move find_matching_gpu_arch() back to test_runner.py - #3972
Merged
Merged
Conversation
…m github_actions_utils.py
ScottTodd
approved these changes
Mar 13, 2026
Comment on lines
+107
to
+109
| for i in range(len(arch_str) - 1, 1, -1): | ||
| pattern = arch_str[:i] + "X" | ||
| possible_patterns.append(pattern) |
Member
There was a problem hiding this comment.
nit: reversed iteration order makes this code tricky to read. Could be worth a comment or something like sorting/reversing then iterating
…o two digits after gfx
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Moving the function out of github_actions_utils.py as per this comment in #3595.
Technical Details
NA
Test Plan
CI tests handled by test_runner.py should continue to run.
Test Result
NA
Submission Checklist