Repository navigation
Add myself as a CODEOWNER for github_actions_utils.py - #3951
Merged
Merged
Conversation
Member
Author
Member
Author
|
Might be worth renaming that file to |
HereThereBeDragons
approved these changes
Mar 13, 2026
HereThereBeDragons
left a comment
HereThereBeDragons
left a comment
Contributor
There was a problem hiding this comment.
i like the idea of renaming it to github_actions_api.[y
btw it seems like we want to have a separate common utility to detect gpus and manipulate gpu visibility. (including what we do for torch unittests)
ScottTodd
added a commit
to ScottTodd/TheRock
that referenced
this pull request
Mar 13, 2026
Follow-up to ROCm#3951. The old name attracted unrelated utility code from contributors who treated it as a general-purpose dumping ground. The new name makes the module's scope explicit: GitHub Actions REST API client and workflow commands. Added TODOs on functions that don't belong (GPU/rocminfo helpers, is_asan) to move them to appropriate modules later. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 task done
ScottTodd
added a commit
that referenced
this pull request
Mar 18, 2026
## Motivation Follow-up to #3951. The "utils" part of the file name was attracting code contributions unrelated to the core design of this module. I think naming as "github_actions_api" will make this more clear. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Claude <noreply@anthropic.com>
amd-chiranjeevi
pushed a commit
that referenced
this pull request
Mar 23, 2026
## Motivation Follow-up to #3951. The "utils" part of the file name was attracting code contributions unrelated to the core design of this module. I think naming as "github_actions_api" will make this more clear. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Code unrelated to the github actions API keeps landing in this file as if it were a general utility:
See the comment at the top of the file:
TheRock/build_tools/github_actions/github_actions_utils.py
Lines 4 to 7 in ca2a06c
Submission Checklist