Revert "Remove comgr delay-load stub; statically link LLVM into comgr"#3877
Revert "Remove comgr delay-load stub; statically link LLVM into comgr"#3877chiranjeevipattigidi wants to merge 1 commit into
Conversation
marbre
left a comment
There was a problem hiding this comment.
ERROR: /root/.cache/bazel/_bazel_root/35c03de1b96cb539bbf04926e943e4d4/external/jax/jaxlib/rocm/BUILD:387:19: Linking external/jax/jaxlib/rocm/_hybrid.so failed: missing input file '@@local_config_rocm//rocm:rocm_dist/lib/libamd_comgr_stub.a'
seems like this rather needs a fix in JAX or at some other place. The revert is not the right long term fix. Before accepting a temporarily revert we should triage the root cause more carefully.
|
Neither of these are good candidates for revert. For build issues not covered by CI, please fix forward (and consider how to add CI coverage so it doesn't happen again). |
stellaraccident
left a comment
There was a problem hiding this comment.
See above comment. Fix these other issues forward.
Jax has a really fragile manual list of libraries that needs update. Until that is fixed in a more robust way, we can't block landing changes like this (there is another one coming today that will also change the list of libraries Jax must bundle). |
Reverts #3731
Jax (v0.8.2 , v0.9.0) builds are failing due missing of
libamd_comgr_stub.aduring linking processmore details: #3876
Test Plan
Testing: https://github.com/ROCm/TheRock/actions/runs/22904894874
Test Result
TBD