Skip to content

Install rocm-develop packages during torch testing #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darren-amd wants to merge 7 commits into from
Closed

Install rocm-develop packages during torch testing #3814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
248318d
Install develop packages during torch tests and re-enable the skipped…
darren-amd Mar 5, 2026
f407a12
Adjusting develop package to use tagged version
darren-amd Mar 5, 2026
6e4311d
Temporary change for testing
darren-amd Mar 5, 2026
0dc2541
[test] upgrade rocm-sdk package
darren-amd Mar 5, 2026
a733645
Undo temporary change for testing
darren-amd Mar 6, 2026
db61226
Adjust develop package to resolve from torch version instead of expli…
darren-amd Mar 6, 2026
620e0d9
Change to support uv
darren-amd Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/test_pytorch_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,20 @@ jobs:
--index-subdir=${{ inputs.amdgpu_family }} \
--activate-in-future-github-actions-steps

# TODO: If setup_venv.py switches to uv, update this to use uv pip install.
- name: Install rocm[devel]
run: |
ROCM_VERSION=$(python -c "from importlib.metadata import version; print(version('rocm'))")
python -m pip install \
--index-url="${{ inputs.package_index_url }}/${{ inputs.amdgpu_family }}" \
"rocm[devel]==${ROCM_VERSION}"
Comment on lines +142 to +148
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came up in discussion with @stellaraccident yesterday. We need to test both with and without rocm[devel] installed. Can't only test with rocm[devel] installed, as that would allow production impacting issues to slip through our testing.

(Another option would be to make the torch packages always depend on rocm[devel] packages, but we'd really rather not do that and inflict the larger package installs on all users)


# hipconfig --rocmpath points to the devel package root so PyTorch's
# _find_rocm_home() resolves correctly.
- name: Set ROCM_PATH
run: |
echo "ROCM_PATH=$(hipconfig --rocmpath)" >> $GITHUB_ENV

- name: Install test requirements
run: |
python -m pip install -r external-builds/pytorch/requirements-test.txt
Expand Down
10 changes: 10 additions & 0 deletions external-builds/pytorch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,16 @@ python run_pytorch_smoke_tests.py -- \

### Running full PyTorch tests

> [!WARNING]
> Our CI currently tests with `rocm[devel]` installed alongside `torch` because
> some tests require development headers at runtime. If you are running tests
> locally, install the devel packages and set `ROCM_PATH` accordingly:
>
> ```bash
> pip install "rocm[devel]" --index-url <your-index-url>
> export ROCM_PATH=$(hipconfig --rocmpath)
> ```

We have a [`run_pytorch_tests.py`](run_pytorch_tests.py) script
which runs PyTorch unit tests using pytest with additional test exclusion
capabilities tailored for AMD ROCm GPUs. See the script for detailed
Expand Down
9 changes: 0 additions & 9 deletions external-builds/pytorch/skip_tests/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,6 @@
# 'num_host_free': 0, 'reserved_bytes.allocated': 0, 'reserved_bytes.current': 0, 'reserved_bytes.freed': 0,
# 'reserved_bytes.peak': 0, 'segment.allocated': 0, 'segment.current': 0, 'segment.freed': 0, 'segment.peak': 0})
"test_host_memory_stats",
# THIS IS AN OLD ERROR
# In file included from /home/tester/.cache/torch_extensions/py312_cpu/dummy_allocator/main_hip.cpp:5:
# /home/tester/TheRock/.venv/lib/python3.12/site-packages/torch/include/ATen/hip/Exceptions.h:4:10: fatal error: hipblas/hipblas.h: No such file or directory
# 4 | #include <hipblas/hipblas.h>
# | ^~~~~~~~~~~~~~~~~~~
# compilation terminated.
# NEW ERROR
# RuntimeError: Error building extension 'dummy_allocator'
"test_mempool_with_allocator",
# Change detector test (Cublaslt vs Cublas depending on gcn_arch and torch version)
# Always skip as this test is very basic and needs manual intervention for new architectures
# See
Expand Down
4 changes: 0 additions & 4 deletions external-builds/pytorch/skip_tests/pytorch_2.10.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
"test_memory_snapshot_with_cpp",
# AssertionError: Scalars are not equal!
"test_mempool_ctx_multithread",
# RuntimeError: Error building extension 'dummy_allocator'
"test_mempool_empty_cache_inactive",
# RuntimeError: Error building extension 'dummy_allocator_v1'
"test_mempool_limited_memory_with_allocator",
# OSError: libhiprtc.so: cannot open shared object file: No such file or directory
# File "/home/tester/TheRock/.venv/lib/python3.12/site-packages/torch/cuda/_utils.py", line 57, in _get_hiprtc_library
# lib = ctypes.CDLL("libhiprtc.so")
Expand Down
9 changes: 0 additions & 9 deletions external-builds/pytorch/skip_tests/pytorch_2.11.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@
"test_memory_snapshot_with_cpp",
# AssertionError: Scalars are not equal!
"test_mempool_ctx_multithread",
# RuntimeError: Error building extension 'dummy_allocator'
"test_mempool_empty_cache_inactive",
# RuntimeError: Error building extension 'dummy_allocator_v1'
"test_mempool_limited_memory_with_allocator",
# new for pytorch 2.11
# RuntimeError: Error building extension 'dummy_allocator_v3'
"test_tensor_delete_after_allocator_delete",
# RuntimeError: Error building extension 'dummy_allocator'
"test_deleted_mempool_not_used_on_oom",
# ModuleNotFoundError: No module named 'torchvision'
"test_resnet",
# RuntimeError: miopenStatusUnknownError
Expand Down
4 changes: 0 additions & 4 deletions external-builds/pytorch/skip_tests/pytorch_2.8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@
"test_memory_snapshot_script",
"test_memory_snapshot_with_cpp",
"test_mempool_ctx_multithread",
# RuntimeError: Error building extension 'dummy_allocator'
"test_mempool_empty_cache_inactive",
# RuntimeError: Error building extension 'dummy_allocator_v1'
"test_mempool_limited_memory_with_allocator",
# This test was fixed in torch 2.9, see
# https://github.com/ROCm/TheRock/issues/2206
"test_hip_device_count",
Expand Down
4 changes: 0 additions & 4 deletions external-builds/pytorch/skip_tests/pytorch_2.9.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
"test_memory_snapshot_with_cpp",
# AssertionError: Scalars are not equal!
"test_mempool_ctx_multithread",
# RuntimeError: Error building extension 'dummy_allocator'
"test_mempool_empty_cache_inactive",
# RuntimeError: Error building extension 'dummy_allocator_v1'
"test_mempool_limited_memory_with_allocator",
# for whatever reason these are also flaky: if run standalone they pass?
# AttributeError: module 'torch.backends.cudnn.rnn' has no attribute 'fp32_precision'
"test_fp32_precision_with_float32_matmul_precision",
Expand Down
Loading