Enabling update alternative/symlink for SLES os profile#3804
Closed
arvindcheru wants to merge 1 commit into
Closed
Enabling update alternative/symlink for SLES os profile#3804arvindcheru wants to merge 1 commit into
arvindcheru wants to merge 1 commit into
Conversation
arvindcheru
force-pushed
the
users/acheruva/test_native_linux_packages_mar6
branch
from
69214cf to
1ee6f3a
Compare
nunnikri
requested changes
Mar 6, 2026
| print("\nInstalling update-alternatives (SLES prerequisite)...") | ||
| try: | ||
| result = subprocess.run( | ||
| ["zypper", "install", "-y", "update-alternatives"], |
Contributor
There was a problem hiding this comment.
This should be in yml workflow. Not in test script
Contributor
Author
|
Changes will be updated in #3126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request adds a prerequisite installation step for SLES systems in the
install_rpm_packagesThe main change ensures that
update-alternativesis installed before attempting to install ROCm packages (to support the default rocm install prefix)Technical Details
SLES-specific installation improvement:
update-alternativesusingzypperbefore installing ROCm packages on SLES systems, including error handling and informative logging.Test Plan
Test Result
https://github.com/arvindcheru/TheRock/actions/runs/22650614180
https://github.com/arvindcheru/TheRock/actions/runs/22650522511
Submission Checklist