Skip to content

[hipDNN] Addressing some small fixes in ROCm wheels tests #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mousdahl-amd merged 3 commits into from
Mar 2, 2026
+5 −2
Merged

[hipDNN] Addressing some small fixes in ROCm wheels tests #3652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c25e5a
Some small fixes to address PR comments
mousdahl-amd Feb 26, 2026
fdeac7e
Fixing syntax error in libraries_test.py
mousdahl-amd Feb 27, 2026
bdfb22a
Merge branch 'main' into users/mousdahl-amd/hipdnn_post_wheel_cleanup
mousdahl-amd Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/devel_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def testSharedLibrariesLoad(self):
extra_setup = ""
if (
"hipdnn_plugins" in str(so_path) or "test_plugins" in str(so_path)
) and sys.platform == "win32":
) and platform.system() == "Windows":
# hipdnn plugins have dependencies on other libraries (e.g. miopen).
# In a real-world scenario, hipdnn_backend loads these plugins, and
# the dependencies are found because they reside in the same directory
Expand Down
5 changes: 4 additions & 1 deletion build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/libraries_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import importlib
import os
from pathlib import Path
import platform
import subprocess
import sys
import sysconfig
Expand Down Expand Up @@ -63,7 +64,9 @@ def testSharedLibrariesLoad(self):
continue

extra_setup = ""
if "hipdnn_plugins" in str(so_path) and sys.platform == "win32":
if (
"hipdnn_plugins" in str(so_path) or "test_plugins" in str(so_path)
) and platform.system() == "Windows":
# hipdnn plugins have dependencies on other libraries (e.g. miopen).
# In a real-world scenario, hipdnn_backend loads these plugins, and
# the dependencies are found because they reside in the same directory
Expand Down
Loading