Skip to content

[hipDNN] Removing unnecessary dependencies on spdlog / fmt for dnn-providers #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mousdahl-amd merged 10 commits into from
Mar 3, 2026
Merged

[hipDNN] Removing unnecessary dependencies on spdlog / fmt for dnn-providers #3609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3177841
Removing unnecessary dependencies on spdlog / fmt for dnn-providers
mousdahl-amd Feb 25, 2026
768f1c9
Attempt to remove it from IREE dnn provider deps
mousdahl-amd Feb 25, 2026
2c88d96
Merge branch 'main' into users/mousdahl-amd/hipdnn_remove_sdplog
mousdahl-amd Feb 25, 2026
bd4a4f8
Removing spdlog/fmt from installed artifacts
mousdahl-amd Feb 26, 2026
bffa413
Revert "Removing spdlog/fmt from installed artifacts"
mousdahl-amd Feb 26, 2026
6925d6b
Merge branch 'main' into users/mousdahl-amd/hipdnn_remove_sdplog
mousdahl-amd Feb 26, 2026
6536353
Another attempt to remove artifacts for spdlog / fmt
mousdahl-amd Feb 26, 2026
af0ffaa
Merge branch 'users/mousdahl-amd/hipdnn_remove_sdplog' of github.com:…
mousdahl-amd Feb 26, 2026
98bc2d3
Merge branch 'main' into users/mousdahl-amd/hipdnn_remove_sdplog
mousdahl-amd Feb 27, 2026
f591b28
Merge branch 'main' into users/mousdahl-amd/hipdnn_remove_sdplog
mousdahl-amd Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions BUILD_TOPOLOGY.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,17 +571,17 @@ artifact_deps = ["core-runtime", "core-hip", "spdlog"]
[artifacts.miopenprovider]
artifact_group = "ml-libs"
type = "target-neutral"
artifact_deps = ["core-runtime", "core-hip", "miopen", "hipdnn", "spdlog"]
artifact_deps = ["core-runtime", "core-hip", "miopen", "hipdnn"]

[artifacts.hipblasltprovider]
artifact_group = "ml-libs"
type = "target-neutral"
artifact_deps = ["core-runtime", "core-hip", "blas", "hipdnn", "spdlog"]
artifact_deps = ["core-runtime", "core-hip", "blas", "hipdnn"]

[artifacts.hipdnn-samples]
artifact_group = "ml-libs"
type = "target-specific"
artifact_deps = ["core-runtime", "core-hip", "miopen", "hipdnn", "miopenprovider", "spdlog"]
artifact_deps = ["core-runtime", "core-hip", "miopen", "hipdnn", "miopenprovider"]

# --- IREE Integration ---

Expand All @@ -594,7 +594,7 @@ disable_platforms = ["windows"]
[artifacts.fusilliprovider]
artifact_group = "iree-libs"
type = "target-neutral"
artifact_deps = ["core-runtime", "core-hip", "hipdnn", "spdlog", "iree-compiler"]
artifact_deps = ["core-runtime", "core-hip", "hipdnn", "iree-compiler"]
disable_platforms = ["windows"]

# --- Media Integration ---
Expand Down
2 changes: 0 additions & 2 deletions iree-libs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,8 @@ if(THEROCK_ENABLE_FUSILLIPROVIDER)
fusilli
hipDNN
therock-flatbuffers
therock-fmt
therock-googletest
therock-nlohmann-json
therock-spdlog
RUNTIME_DEPS
hip-clr
hipDNN
Expand Down
10 changes: 2 additions & 8 deletions ml-libs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@ if(THEROCK_ENABLE_HIPDNN)
amd-hip
BUILD_DEPS
therock-googletest
therock-fmt
therock-spdlog
RUNTIME_DEPS
hip-clr
therock-flatbuffers
therock-fmt
therock-nlohmann-json
therock-spdlog
)
therock_cmake_subproject_glob_c_sources(hipDNN
SUBDIRS
Expand Down Expand Up @@ -236,8 +236,6 @@ if(THEROCK_ENABLE_MIOPENPROVIDER)
therock-googletest
therock-flatbuffers
therock-nlohmann-json
therock-fmt
therock-spdlog
RUNTIME_DEPS
MIOpen
)
Expand Down Expand Up @@ -282,8 +280,6 @@ if(THEROCK_ENABLE_HIPBLASLTPROVIDER)
therock-googletest
therock-flatbuffers
therock-nlohmann-json
therock-fmt
therock-spdlog
RUNTIME_DEPS
hipBLAS-common
hipBLASLt
Expand Down Expand Up @@ -328,8 +324,6 @@ if(THEROCK_ENABLE_HIPDNN_SAMPLES)
hipDNN
therock-flatbuffers
therock-nlohmann-json
therock-fmt
therock-spdlog
RUNTIME_DEPS
miopenprovider
)
Expand Down
5 changes: 3 additions & 2 deletions profiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,14 +258,15 @@ endif(THEROCK_BUILD_TESTING)
"llvm/lib"
CMAKE_INCLUDES
therock_explicit_finders.cmake
BUILD_DEPS
therock-spdlog
therock-fmt
RUNTIME_DEPS
amdsmi
aqlprofile
hip-clr
rocprofiler-register
rocprofiler-sdk
therock-spdlog
therock-fmt
${THEROCK_BUNDLED_LIBDRM}
${THEROCK_BUNDLED_SQLITE3}
)
Expand Down
9 changes: 0 additions & 9 deletions third-party/fmt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,4 @@ therock_cmake_subproject_provide_package(
therock-fmt fmt lib/cmake/fmt)
therock_cmake_subproject_activate(therock-fmt)

therock_provide_artifact(fmt
TARGET_NEUTRAL
DESCRIPTOR artifact-fmt.toml
COMPONENTS
dev
SUBPROJECT_DEPS
therock-fmt
)

add_dependencies(therock-third-party therock-fmt)
2 changes: 0 additions & 2 deletions third-party/fmt/artifact-fmt.toml
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions third-party/spdlog/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,4 @@ therock_cmake_subproject_declare(therock-spdlog
therock_cmake_subproject_provide_package(therock-spdlog spdlog lib/cmake)
therock_cmake_subproject_activate(therock-spdlog)

therock_provide_artifact(spdlog
TARGET_NEUTRAL
DESCRIPTOR artifact-spdlog.toml
COMPONENTS
dev
SUBPROJECT_DEPS
therock-spdlog
)

add_dependencies(therock-third-party therock-spdlog)
2 changes: 0 additions & 2 deletions third-party/spdlog/artifact-spdlog.toml
View file
Open in desktop

This file was deleted.

Loading