Add support for gfx900 cards by lucbruni-amd · Pull Request #3564 · ROCm/TheRock

lucbruni-amd · 2026-02-23T19:02:47Z

Motivation

Resolves #2737

Technical Details

Adds a therock_add_amdgpu_target call for gfx900 in the gfx90X family block. The target is registered like the other gfx90X targets (gfx906, gfx908, gfx90a), so it is included in THEROCK_AMDGPU_TARGETS and the corresponding family lists, and the same per-project exclusions are respected when building for gfx900.

Test Plan

Specify gfx90X-all instead of gfx90X-dcgpu in nightly build workflows to include this arch in the resulting build. Label this PR accordingly (the GitHub label gets processed and is truncated to hit the entry here (as per ci_behavior_manipulation.md). Should observe passing tests, and failures only when unrelated.

Test Result

https://github.com/ROCm/TheRock/actions/runs/22457555142/job/65043306378?pr=3564

Submission Checklist

[x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

geomin12

code looks good! looks like it built too which is awesome, i think the failing sanity check is due to an infra test machine, which we will look into

one thing though: please add a good description in the PR :) and tag that gfx900 issue as well

geomin12

lgtm, the sanity check is an infra issue and unrelated

thanks for this work :)

i would also recommend getting a build folk reviewing as well

HereThereBeDragons

lgtm other than the comment.

and do you have any gfx900 to test if it actually runs?

HereThereBeDragons · 2026-02-25T17:52:38Z

 """

 #############################################################################################
 # NOTE: when doing changes here, also check that they are done in new_amdgpu_family_matrix.py


please note this message :)
i recommend adding there a new section "all" to it and not just rename "dcgpu"

Added a new section in new_amdgpu_family_matrix.py.

I don't have a gfx900 on hand, but perhaps the issue reporters @oldschoola and @GreenShadows could check if they encounter any issues with the build?

since gfx906 is a strict superset of gfx900 you could just run the sanity checks on a gfx906 machine with the override and be very certain that its will be fine on gfx900 too, linux kernel level bugs excepted.

HereThereBeDragons · 2026-02-26T18:42:41Z

you need to rework your pr due to this: #2869
you can leave the new_amdgpu_matrix.py away. i will take care of it.

…atrix.py." This reverts commit 5a7cac8.

lucbruni-amd · 2026-02-26T19:03:29Z

@HereThereBeDragons reworked this PR in light of #2869 landing.

EDIT: Also reverted my changes to new_amdgpu_family_matrix.py.

HereThereBeDragons

as this is now a separate gpu: you will also need to adjust all those workflows listed in #2869 and the jax workflow from #3633

HereThereBeDragons

lgtm
but please run a manual ci run to build gfx900 before merging.

geomin12

FYI it passed: https://github.com/ROCm/TheRock/actions/runs/22457555142/job/65043306378?pr=3564

lucbruni-amd · 2026-03-11T17:42:46Z

Resolved a merge conflict as a result of #3821 landing. Also removed libhipcxx exclusion (see #2946).

oldschoola · 2026-03-11T20:14:13Z

The roadmap should be also updated no?
https://github.com/ROCm/TheRock/blob/main/ROADMAP.md

lucbruni-amd · 2026-03-12T14:37:09Z

Thanks @oldschoola. Opened a PR for that mentioned above.

## Motivation gfx900 support was recently introduced into the system via #3564. However, AOTriton currently does not support gfx900, leading to PyTorch build failures when this architecture is detected. eg failure log: https://github.com/ROCm/TheRock/actions/runs/23181751945/job/67356031342 Previously, PyTorch builds were failing due to missing package requirements (see: #3988). Those requirements were later uploaded manually: https://github.com/ROCm/TheRock/tree/main/build_tools/third_party/s3_management#adding-a-new-package-dependency To ensure stable builds, this PR adds gfx900 to the AOTRITON_UNSUPPORTED_ARCHS list within the PyTorch build script, preventing AOTriton from attempting compilation on unsupported hardware. ## Test Plan Linux Rocm Run: https://github.com/ROCm/TheRock/actions/runs/23189631595 pytorch: https://github.com/ROCm/TheRock/actions/runs/23198946201 ## Test Result: gfx900 pytorch builds passed. ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

## Motivation Update `ROADMAP.md` to reflect recently added support. ## Technical Details `gfx103X-all` builds passing for Linux/Windows: #3763 (Pytorch failing until ROCm/rocm-libraries#5141 lands) `gfx900` builds passing: #3564 `gfx90c` builds awaiting ROCm/rocm-libraries#5282 to go green ## Test Plan `gfx90c` builds to be tested (#3818) ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

i-chaochen · 2026-05-08T13:33:16Z

@lucbruni-amd why we still need to support gfx900/gfx906?

https://rocm.docs.amd.com/en/latest/compatibility/compatibility-matrix.html
AFAIK ROCm/LLVM is supporting since gfx908, these build wouldn't work at all.

GreenShadows · 2026-05-08T13:47:03Z

@lucbruni-amd why we still need to support gfx900/gfx906?

https://rocm.docs.amd.com/en/latest/compatibility/compatibility-matrix.html AFAIK ROCm/LLVM is supporting since gfx908, these build wouldn't work at all.

The GFX906 works fine. I'm surprised by these anti-consumer and conflicting suggestions.

Add support for gfx900 cards

611d6d9

lucbruni-amd requested a review from geomin12 February 23, 2026 19:02

github-project-automation Bot added this to TheRock Triage Feb 23, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Feb 23, 2026

geomin12 added the gfx90X-dcgpu label Feb 23, 2026

Build entire gfx90X family nightly.

26a7b53

geomin12 reviewed Feb 24, 2026

View reviewed changes

lucbruni-amd marked this pull request as ready for review February 24, 2026 15:40

Unify Linux/Windows amdgpu family entries for gfx90X.

250517c

lucbruni-amd requested review from HereThereBeDragons, ScottTodd, geomin12 and marbre February 24, 2026 15:46

ScottTodd removed their request for review February 24, 2026 19:07

geomin12 approved these changes Feb 25, 2026

View reviewed changes

HereThereBeDragons requested changes Feb 25, 2026

View reviewed changes

Add corresponding entry for gfx90X-all in new_amdgpu_family_matrix.py.

5a7cac8

lucbruni-amd requested a review from HereThereBeDragons February 26, 2026 18:37

lucbruni-amd and others added 3 commits February 26, 2026 13:54

Merge branch 'main' into lb/gfx900-support

7081cb5

Revert "Add corresponding entry for gfx90X-all in new_amdgpu_family_m…

fde573e

…atrix.py." This reverts commit 5a7cac8.

Add comment; fix spacing.

e7cd739

lucbruni-amd added gfx900 and removed gfx90X-dcgpu labels Feb 26, 2026

HereThereBeDragons reviewed Feb 26, 2026

View reviewed changes

Add gfx900 to amdgpu_family workflow inputs.

dcde756

HereThereBeDragons approved these changes Feb 26, 2026

View reviewed changes

HereThereBeDragons mentioned this pull request Feb 27, 2026

Refactor new_amdgpu_family_matrix to use data classes instead of dictionary #3653

Open

muebau mentioned this pull request Mar 6, 2026

No more HWA-Support for gfx900 in Immich Machine Learning 2.4.0 (ROCM) and above immich-app/immich#24734

Closed

4 tasks

This was referenced Mar 6, 2026

[Feature] gfx90c build enablement #3818

Open

[Issue]: Continued APU support required for newer versions of ROCm and Linux ROCm/ROCm#5967

Open

geomin12 approved these changes Mar 9, 2026

View reviewed changes

marbre removed their request for review March 9, 2026 23:31

Merge branch 'main' into lb/gfx900-support

87760b5

lucbruni-amd merged commit ef86d4e into main Mar 11, 2026
14 checks passed

lucbruni-amd deleted the lb/gfx900-support branch March 11, 2026 18:08

github-project-automation Bot moved this from TODO to Done in TheRock Triage Mar 11, 2026

lucbruni-amd mentioned this pull request Mar 12, 2026

ROADMAP.md: gfx103X builds passing; add gfx900/gfx90c rows #3933

Merged

1 task

chiranjeevipattigidi mentioned this pull request Mar 17, 2026

Disable AOTriton for gfx900 in PyTorch builds #4001

Merged

1 task

akostadinov mentioned this pull request Mar 21, 2026

feat: ROCm 7.2 and MIGraphX support immich-app/immich#26178

Merged

flesti mentioned this pull request Apr 17, 2026

Question: Is 5700g supported ? patientx/ComfyUI-Zluda#458

Closed

Conversation

lucbruni-amd commented Feb 23, 2026 • edited by geomin12 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

HereThereBeDragons left a comment

Choose a reason for hiding this comment

Uh oh!

HereThereBeDragons Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

lucbruni-amd Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

IMbackK Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HereThereBeDragons commented Feb 26, 2026

Uh oh!

lucbruni-amd commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HereThereBeDragons left a comment

Choose a reason for hiding this comment

Uh oh!

HereThereBeDragons left a comment

Choose a reason for hiding this comment

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

lucbruni-amd commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

oldschoola commented Mar 11, 2026

Uh oh!

lucbruni-amd commented Mar 12, 2026

Uh oh!

i-chaochen commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GreenShadows commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lucbruni-amd commented Feb 23, 2026 •

edited by geomin12

Loading

IMbackK Mar 9, 2026 •

edited

Loading

lucbruni-amd commented Feb 26, 2026 •

edited

Loading

lucbruni-amd commented Mar 11, 2026 •

edited

Loading

i-chaochen commented May 8, 2026 •

edited

Loading