Set flags for FFT math libs on Windows.#339
Merged
Merged
Conversation
ScottTodd
commented
Apr 2, 2025
Comment on lines
+155
to
+157
| # TODO(#36): enable once `rocfft_aot_helper.exe` can access hiprtc0605.dll | ||
| # "The code execution cannot proceed because hiprtc0605.dll was not found." | ||
| set(_kernel_cache_enable "OFF") |
Member
Author
There was a problem hiding this comment.
The hiprtc0605.dll file exists at TheRock\build\core\clr\dist\bin and is later copied to TheRock\build\math-libs\rocFFT\dist\bin, but it is needed by TheRock\build\math-libs\rocFFT\build\library\src\rocfft_aot_helper.exe during the build, here: https://github.com/ROCm/rocFFT/blob/ee8a6666b414b7db75900cabcf269c88bb9176ed/library/src/CMakeLists.txt#L522-L527
if ( ROCFFT_KERNEL_CACHE_ENABLE )
# ...
add_custom_command(
OUTPUT rocfft_kernel_cache.db
COMMAND ${CMAKE_COMMAND} -E env "LD_LIBRARY_PATH=$ENV{LD_LIBRARY_PATH}:${ROCM_PATH}/${CMAKE_INSTALL_LIBDIR}" "${CMAKE_CURRENT_BINARY_DIR}/rocfft_aot_helper" \"${ROCFFT_BUILD_KERNEL_CACHE_PATH}\" ${ROCFFT_KERNEL_CACHE_PATH} $<TARGET_FILE:rocfft_rtc_helper> ${GPU_TARGETS_AOT}
DEPENDS rocfft_aot_helper rocfft_rtc_helper
COMMENT "Compile kernels into shipped cache file"
)Maybe we can build off of -E env "LD_LIBRARY_PATH=$ENV{LD_LIBRARY_PATH}:${ROCM_PATH}/${CMAKE_INSTALL_LIBDIR}"
Base automatically changed from
users/scotttodd/windows-math-rand-with-clr
to
main
April 3, 2025 15:30
ScottTodd
force-pushed
the
users/scotttodd/windows-math-fft
branch
from
f9fd2f7 to
daad0ce
Compare
marbre
approved these changes
Apr 7, 2025
Member
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
No strong feelings about the naming, just something to eventually keep in mind.
ScottTodd
added a commit
that referenced
this pull request
Apr 7, 2025
Redo of #350 now that #339 is merged. --- Progress on #36. Tests for rocPRIM run on my gfx1100 dev machine: https://gist.github.com/ScottTodd/5c33611469aa1df9d39b816acecbb7f0. ### Warnings I silenced a bunch of warnings that were getting in my way and added some notes to #47 about the remaining warnings since the build logs for rocPRIM were 45MB. Some warnings will be fixed with newer subproject code. rocPRIM in particular is 2 months outdated on `mainline` compared to `develop`, and commits like ROCm/rocPRIM@678701d fix warnings by removing code like ```C++ #ifdef _WIN32 #define ROCPRIM_KERNEL __global__ static #else #define ROCPRIM_KERNEL __global__ #endif ``` that had been causing warnings: ``` 16.8 D:/projects/TheRock/math-libs/rocPRIM/rocprim/include\rocprim\device/device_find_first_of.hpp:53:12: warning: duplicate 'static' declaration specifier [-Wduplicate-decl-specifier] 16.8 53 | static ROCPRIM_KERNEL 16.8 | ^ 16.8 D:/projects/TheRock/math-libs/rocPRIM/rocprim/include\rocprim\config.hpp:46:43: note: expanded from macro 'ROCPRIM_KERNEL' 16.8 46 | #define ROCPRIM_KERNEL __global__ static 16.8 | ^ ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #36.
Now I can build
librocfft.libandhipfft.libwith-DTHEROCK_ENABLE_FFT=ONon Windows.