Add timeouts to test_rocm_wheels.yml#3233
Merged
Merged
Conversation
Prevent hung test jobs from running until the default 6-hour timeout, as we've observed on gfx1151 Linux runners. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
geomin12
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Progress on #1559. When adding Python package tests to CI workflows on #3182 we noticed that this job hit a 6 hour timeout on the
linux-strix-halo-gpu-rocm-5runner: https://github.com/ROCm/TheRock/actions/runs/21533668625/job/62060067637?pr=3182.Technical Details
I chose a 30 minute timeout for the overall job, to catch slow network issues and then a 5 minute timeout for just the test step, to give enough time for the packages to initialize and then catch any hung subprocesses.
Note that we currently skip tests on Linux gfx1151 here:
TheRock/build_tools/github_actions/amdgpu_family_matrix.py
Lines 77 to 87 in 55fa089
TheRock/build_tools/print_driver_gpu_info.py
Lines 24 to 26 in 55fa089
We may want to similarly filter Linux gfx1151 from parts of
rocm-sdk test.Test Plan and Results
Triggered a test run with ROCm version
7.12.0a20260202: https://github.com/ROCm/TheRock/actions/runs/21644961000All tests passed in 1 minute, though the
linux-strix-halo-gpu-rocm-7runner was used for those runs.Submission Checklist