Skip to content

[ASAN][compiler][Comgr] Enable ASAN for Comgr when THEROCK_SANITIZER is ASAN or HOST_ASAN #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lamb-j merged 5 commits into from
Feb 3, 2026
+10 −4
Merged

[ASAN][compiler][Comgr] Enable ASAN for Comgr when THEROCK_SANITIZER is ASAN or HOST_ASAN #3206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbd95be
Enable ASAN for Comgr when THEROCK_SANITIZER is ASAN or HOST_ASAN
lamb-j Feb 2, 2026
ce314b7
Check amd-comgr_SANITIZER override in prehook
lamb-j Feb 2, 2026
e4e16be
remove redundant check of amd_comgr-SANITIZER
lamb-j Feb 2, 2026
7454a1f
Merge branch 'main' into users/jlambert/comgr-asan
lamb-j Feb 2, 2026
7bf5487
Merge branch 'main' into users/jlambert/comgr-asan
lamb-j Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"THEROCK_FLAG_COMGR_DELAY_LOAD": "OFF",
"THEROCK_SANITIZER": "ASAN",
"amd-llvm_SANITIZER": "OFF",
"amd-comgr_SANITIZER": "OFF",
"amd-comgr-impl_SANITIZER": "OFF",
"amd-comgr_SANITIZER": "ASAN",
"amd-comgr-impl_SANITIZER": "ASAN",
"hipcc_SANITIZER": "OFF",
"hipify_SANITIZER": "OFF",
"aqlprofile_SANITIZER": "OFF",
Expand All @@ -61,8 +61,8 @@
"THEROCK_FLAG_COMGR_DELAY_LOAD": "OFF",
"THEROCK_SANITIZER": "HOST_ASAN",
"amd-llvm_SANITIZER": "OFF",
"amd-comgr_SANITIZER": "OFF",
"amd-comgr-impl_SANITIZER": "OFF",
"amd-comgr_SANITIZER": "HOST_ASAN",
"amd-comgr-impl_SANITIZER": "HOST_ASAN",
"hipcc_SANITIZER": "OFF",
"hipify_SANITIZER": "OFF",
"aqlprofile_SANITIZER": "OFF",
Expand Down
6 changes: 6 additions & 0 deletions compiler/pre_hook_amd-comgr.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ endif()

set(COMGR_DISABLE_SPIRV OFF)

# Enable ASAN for Comgr when THEROCK_SANITIZER is set to ASAN or HOST_ASAN
if(THEROCK_SANITIZER STREQUAL "ASAN" OR THEROCK_SANITIZER STREQUAL "HOST_ASAN")
set(ADDRESS_SANITIZER ON)
message(STATUS "Enabling ASAN for Comgr (THEROCK_SANITIZER=${THEROCK_SANITIZER})")
endif()

# Enable comgr tests when LLVM tests are enabled.
if(THEROCK_ENABLE_LLVM_TESTS)
set(BUILD_TESTING ON CACHE BOOL "Enable comgr tests" FORCE)
Expand Down
Loading