script to verify installation#3124
Conversation
There was a problem hiding this comment.
There are some design and logic issues here. Furthermore the PR title and description is not appropriate. This PR is not limited to adding a script and rather aims to "Add testing for native packages" as it also touched the workflow. Furthermore, pre-submit is failing and there are no test results linked.
Take a look into how we test ROCm wheels and especially PyTorch wheels. Testing should go to a separate job. @HereThereBeDragons can give further guidance. Will review again once this was addressed and Laura's reviewed.
| --package-type rpm \ | ||
| --package-folder ${{ env.PACKAGE_DIST_DIR }} \ | ||
| --docker-image ${{ env.BUILD_IMAGE }} | ||
| fi |
There was a problem hiding this comment.
This has some design flaws from my perspective.
- Testing should probably be run in a separate job and should depend on building. This would allow to run the job in a container. Furthermore, this it would be preferred to use a matrix to spawn different distributions.
- The job always run ins a manylinux docker container. Spawning a manylinux container in a manylinux container is not what we want and it should rather match on of the OS profiles.
- Deb testing wont work if installing in the manylinux container. Instead an Ubuntu or Debian container needs to be spawned.
@HereThereBeDragons can give some guidance here as some of the designed are most likely used / considered in the upcoming weekly CI.
There was a problem hiding this comment.
This is pretty large for just a simple test install which could be a narrowed down to 2-3 lines. Printing should be avoided and replaced by proper logging. Following the above comments I also don't see the need to start the container within the script. Haven't looked closer thus I assume there is more to fix.
Motivation
Script which verifies packages can be installed
Technical Details
python script installs packages using apt
Test Plan
test install and uninstall for deb and rpm
Test Result
Submission Checklist