Test Filter Standardization POC - Changes to integrate MIOpen by dileepr1 · Pull Request #3097 · ROCm/TheRock

dileepr1 · 2026-01-26T21:02:45Z

Motivation

This PR is to integrate the Test Filter Standardization POC done in MIOpen to TheRock

Technical Details

The POC in MIOpen is done here: ROCm/rocm-libraries#3513.
This PR modifies test_miopen.py to call the required test categories with CTest.

jayhawk-commits · 2026-01-27T18:44:49Z

A lot of the functions introduced here are not specific to MIOpen. Please move those functions to another python script, that can be leveraged for all ROCm projects.

…nd 'full'

geomin12

i notice it is failing, but this is not sharded!

geomin12 · 2026-01-29T23:44:08Z

i think this is for testing, but let's remember to remove this before merge in

Yes for sure and yes, it is for testing.
Happy to know that there are more set of eyes on this!

geomin12 · 2026-01-29T23:46:57Z

+            "8",
+            "--test-dir",
+            f"{THEROCK_BIN_DIR}/MIOpen",
+            "-V",  # Always run in verbose mode


let's add this

TheRock/build_tools/github_actions/test_executable_scripts/test_rocprim.py

Lines 107 to 109 in d072e26

# shards the tests by running a specific set of tests based on starting test (shard_index) and stride (total_shards)

"--tests-information",

f"{shard_index},,{total_shards}",

so it provides sharding

This is done!

geomin12 · 2026-01-29T23:49:03Z

+        category = "standard"
+
+    # Use AMDGPU_FAMILIES from environment variable, extract gfx<xxx> part
+    gpu_arch = "gfx1151"  # default


prob would avoid a "default" arch, just an empty string is fine. we'll be guaranteed to have a gpu arch, and if none, there's a bigger problem at hand

Makes sense, will change.

This reverts commit 94b2e1b.

…ch for testing

…pen branch for testing" This reverts commit 2d85924.

This reverts commit 73f8fb6.

…onents

This reverts commit 263f70c.

…vindr/ctest_miopen

…ategory}-{gpu_arch}-exclude to {target_name}-{category}-{gpu_arch}-suite

…filters.py now

…job and add `rocblas` to the component directory mapping in `test_filters.py`.

…ocblas` job and add `rocblas` to the component directory mapping in `test_filters.py`." This reverts commit 9efe697.

dileepr1 · 2026-02-24T21:07:24Z

I'm closing this PR since it has got multiple commits pointing to local rocm-libraries branches for testing.
Created a new PR #3595 with the required changes.

## Summary Adds YAML-driven CTest test categorization for the **miopen-provider** plugin so TheRock CI can drive `ctest -L {quick|standard|comprehensive|full}` from the installed `bin/miopen_plugin/` tree via the generic `test_runner.py` (replacing the legacy `test_miopenprovider.py` one-off). More details available at [test_filtering.md](https://github.com/ROCm/TheRock/blob/main/docs/development/test_filtering.md). Paired TheRock branch: [`users/dravindr/tr_miopen_prov`](https://github.com/ROCm/TheRock/tree/users/dravindr/tr_miopen_prov) (PR forthcoming) — switches the `miopenprovider` job's `test_script` to `test_runner.py`, adds `miopenprovider -> miopen_plugin` to `COMPONENT_DIR_MAPPING`, and broadens `artifact-miopenprovider.toml`'s test include to `bin/miopen_plugin/**`. Reference (canonical pattern): [`#3513`](#3513) + [`ROCm/TheRock#3097`](ROCm/TheRock#3097) (miopen). ## Changes ### `dnn-providers/miopen-provider/test_categories.yaml` (new) Added the test_categories.yaml for test selection ### `dnn-providers/miopen-provider/CMakeLists.txt` - Set `ROCM_LIBRARIES_ROOT` (guarded `if NOT DEFINED`) so `shared/ctest/TestCategories.cmake` is discoverable from the monorepo root. - After `finalize_test_targets(...)`, call `apply_test_category_labels()` once per test binary, writing both sets of `_quick_suite` / `_standard_suite` / `_comprehensive_suite` / `_full_suite` entries into a single install-time `CTestTestfile.cmake` with relative paths (`../miopen_plugin_tests`, `../miopen_plugin_integration_tests`). - Install the YAML-generated `CTestTestfile.cmake` to `bin/miopen_plugin/` when shared/ctest is available; otherwise fall back to the project's existing `install_provider_ctest_files()` so standalone / sparse checkouts that lack `shared/ctest/` keep working with their current unlabeled install file. ### `.github/actions/ci-env/action.yml` *(WIP — revert before merge)* Bumps the `therock-ref` output from the pinned 2026-05-29 SHA (`685f8c3b890063...`) to the paired TheRock branch `users/dravindr/tr_miopen_prov`. This file is the single source of truth for `therock-ci-linux.yml`, `therock-ci-windows.yml`, `therock-ci.yml`, `therock-test-component.yml`, and `therock-test-packages.yml`, so this one edit replaces what would otherwise be four parallel diffs. **Must be reverted to a pinned `ROCm/TheRock` SHA before merge**, once the paired TheRock PR lands and gives us a stable commit on `main`. ## Test plan - [x] CI build (Linux) on `users/dravindr/tr_miopen_prov` produces a `miopenprovider` artifact whose `bin/miopen_plugin/CTestTestfile.cmake` lists all 8 `*_suite` entries with labels. - [x] CI build (Windows) ditto. - [x] `therock-test-component.yml` / `therock-test-packages.yml` runs of the `miopenprovider` job invoke `test_runner.py` with `TEST_COMPONENT=miopenprovider` and `TEST_TYPE=quick` and pass. - [x] Revert `.github/actions/ci-env/action.yml` to a pinned `ROCm/TheRock` SHA once the paired TheRock PR is merged. Made with [Cursor](https://cursor.com) --------- Co-authored-by: Cursor <cursoragent@cursor.com>

dileepr1 assigned amd-aakash, nunnikri and jayhawk-commits Jan 26, 2026

github-project-automation Bot added this to TheRock Triage Jan 26, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Jan 26, 2026

dileepr1 force-pushed the users/dravindr/ctest_miopen branch from ae8d352 to 66edc66 Compare January 26, 2026 23:04

dileepr1 force-pushed the users/dravindr/ctest_miopen branch from 3cc11fd to f8fc406 Compare January 27, 2026 21:14

Dileep Ravindranathan added 2 commits January 27, 2026 15:19

add changes to integrate miopen test filter standardization in TheRock

5ed1b31

fix pre-commit errors

d436a36

dileepr1 force-pushed the users/dravindr/ctest_miopen branch from f8fc406 to d436a36 Compare January 27, 2026 21:21

Dileep Ravindranathan added 2 commits January 27, 2026 15:50

Use the categories 'quick' and 'standard' for the TEST_TYPE 'smoke' a…

8ad4312

…nd 'full'

temporary adding test_filter branch to confirm functionality

94b2e1b

dileepr1 requested a review from a team as a code owner January 28, 2026 14:43

CTest should be called from the correct test directory

f3998b6

geomin12 reviewed Jan 29, 2026

View reviewed changes

Dileep Ravindranathan and others added 14 commits January 30, 2026 09:45

Add sharding and remove default gpu setting.

dada006

Revert "temporary adding test_filter branch to confirm functionality"

09e8653

This reverts commit 94b2e1b.

temporarily pointing to latest version of rocm-libs ctest_miopen bran…

2d85924

…ch for testing

Merge branch 'main' into users/dravindr/ctest_miopen

95e8e10

Revert "temporarily pointing to latest version of rocm-libs ctest_mio…

0b3fef7

…pen branch for testing" This reverts commit 2d85924.

point to rocm-libs ctest_miopen branch for testing

73f8fb6

resolving merge conflicts

90cc8e4

Revert "point to rocm-libs ctest_miopen branch for testing"

090f44b

This reverts commit 73f8fb6.

Use latest ctest_miopen from rocm-libs

263f70c

Move the changes to a generic test file which can be used by all comp…

5bac5ab

…onents

Merge branch 'main' into users/dravindr/ctest_miopen

1cdab25

Revert "Use latest ctest_miopen from rocm-libs"

b6eb987

This reverts commit 263f70c.

Use latest ctest_miopen from rocm-libs with increased test timeouts

8b01c01

point to rocm-libs ctest_miopen branch with changes - 02/05

468a1ba

Dileep Ravindranathan and others added 8 commits February 6, 2026 13:38

Pass env vars to CTest

494c848

Merge branch 'main' of https://github.com/ROCm/TheRock into users/dra…

ba76707

…vindr/ctest_miopen

Changes to include renaming of tests from the format {target_name}-{c…

a8251fc

…ategory}-{gpu_arch}-exclude to {target_name}-{category}-{gpu_arch}-suite

Restore test_miopen.py from main since tests are triggered with test_…

9dcfbab

…filters.py now

Merge branch 'main' into users/dravindr/ctest_miopen

346a0b2

Update test configuration to use test_filters.py for the rocblas …

9efe697

…job and add `rocblas` to the component directory mapping in `test_filters.py`.

Revert "Update test configuration to use test_filters.py for the `r…

1ed302c

…ocblas` job and add `rocblas` to the component directory mapping in `test_filters.py`." This reverts commit 9efe697.

Resolve merge conflicts with rocm-libraries

6310234

dileepr1 closed this Feb 24, 2026

github-project-automation Bot moved this from TODO to Done in TheRock Triage Feb 24, 2026

dileepr1 deleted the users/dravindr/ctest_miopen branch March 13, 2026 18:47

dileepr1 mentioned this pull request May 29, 2026

[miopen-provider] Add test filter standardization ROCm/rocm-libraries#7901

Merged

4 tasks done

Navigation Menu

Repository navigation

Test Filter Standardization POC - Changes to integrate MIOpen - #3097

Test Filter Standardization POC - Changes to integrate MIOpen#3097
dileepr1 wants to merge 27 commits into
mainfrom
users/dravindr/ctest_miopen

dileepr1 commented Jan 26, 2026

Uh oh!

jayhawk-commits commented Jan 27, 2026

Uh oh!

geomin12 left a comment

Uh oh!

geomin12 Jan 29, 2026

Uh oh!

dileepr1 Jan 30, 2026

Uh oh!

geomin12 Jan 29, 2026

Uh oh!

dileepr1 Feb 18, 2026

Uh oh!

geomin12 Jan 29, 2026

Uh oh!

dileepr1 Jan 30, 2026

Uh oh!

dileepr1 Feb 18, 2026

Uh oh!

dileepr1 commented Feb 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	# shards the tests by running a specific set of tests based on starting test (shard_index) and stride (total_shards)
	"--tests-information",
	f"{shard_index},,{total_shards}",

Conversation

dileepr1 commented Jan 26, 2026

Motivation

Technical Details

Uh oh!

jayhawk-commits commented Jan 27, 2026

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

geomin12 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

dileepr1 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

geomin12 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

dileepr1 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

geomin12 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

dileepr1 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

dileepr1 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

dileepr1 commented Feb 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants