Fixing warning while setting up ROCm repo in debian.#3006
Merged
Conversation
The Debian release file didnt had hash values like md4 sha256. The new change adds them to the release file. Also the big regenerate_repo_metadata_from_s3 fn has been split into deb/rpm smaller functions for better maintanance
marbre
reviewed
Jan 20, 2026
Member
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
I think this needs more refactoring. With the current approach everything is integrated into the upload_package_repo.py script but to me it seems to conflict with the following:
- Manually promoting and uploading the packages to repo.amd.com.
- Moving the index.html generation to an AWS Lambda (needed for dev, nigbhtly, pre and stable releases)
To me it seems with need a different approach here.
CC @amd-aakash @suchitravemuri1
Contributor
Author
raramakr
pushed a commit
that referenced
this pull request
Jan 26, 2026
The Debian release file didnt had hash values like md5 sha256. The new change adds them to the release file. Also the big regenerate_repo_metadata_from_s3 fn has been split into deb/rpm smaller functions for better maintanance ## Motivation Latest Debian standards expect hash values like md5, sha256 in the Release file. Current release file didnt had hash values like md5 sha256. The new change adds them to the release file. Also the big regenerate_repo_metadata_from_s3 fn has been split into deb/rpm smaller functions for easier maintenance Internal ticket tracking it ROCM-1331 ## Test Plan The debian packages build shoudnt fail and setting up repo shouldnt show any warnings. ## Test Result Test run was success in https://github.com/ROCm/TheRock/actions/runs/21155463197/job/60839415580 Packages are available in https://rocm.devreleases.amd.com/deb/20260120-21085375476/dists/stable/index.html With this repo setting is not showing any warnings. ``` echo "deb [trusted=yes] https://rocm.devreleases.amd.com/deb/20260120-21085375476 stable main" > /etc/apt/sources.list.d/rocm.list apt update Hit:1 http://archive.ubuntu.com/ubuntu noble InRelease Ign:2 https://rocm.devreleases.amd.com/deb/20260120-21085375476 stable InRelease Hit:3 http://security.ubuntu.com/ubuntu noble-security InRelease Hit:4 http://archive.ubuntu.com/ubuntu noble-updates InRelease Hit:5 http://archive.ubuntu.com/ubuntu noble-backports InRelease Get:6 https://rocm.devreleases.amd.com/deb/20260120-21085375476 stable Release [759 B] Ign:7 https://rocm.devreleases.amd.com/deb/20260120-21085375476 stable Release.gpg Get:8 https://rocm.devreleases.amd.com/deb/20260120-21085375476 stable/main amd64 Packages [9958 B] Fetched 10.7 kB in 1s (18.4 kB/s) Reading package lists... Done Building dependency tree... Done Reading state information... Done 20 packages can be upgraded. Run 'apt list --upgradable' to see them. ``` Release file contents now has hash values: https://rocm.devreleases.amd.com/deb/20260120-21085375476/dists/stable/Release ``` Origin: AMD ROCm Label: ROCm dev Packages Suite: stable Codename: stable Architectures: amd64 Components: main Description: ROCm APT Repository Date: Tue, 20 Jan 2026 00:54:45 UTC MD5Sum: 38847cd83192631a2ab1657567fe2f6f 49251 main/binary-amd64/Packages a5448e780baf917188ac93c19dcef69f 9958 main/binary-amd64/Packages.gz SHA1: 6d3e01aa59e971cd1c042613fb80b04c387d918c 49251 main/binary-amd64/Packages abff58d8f3e8d6366a3eac30b66d8c31d9a09cb6 9958 main/binary-amd64/Packages.gz SHA256: f8f4963e74fefc4deb4c0326281e860f453cf202a412ebc9a5071443fdc62f83 49251 main/binary-amd64/Packages a63db6d17ab66c627330666e5e223ce149e2745bbad8cfb473cdde62017d689d 9958 main/binary-amd64/Packages.gz ```
araravik-psd
added a commit
that referenced
this pull request
Jan 29, 2026
…ng (#3100) Packaging builds were failing when artifactories for certain gfx architectures were missing. These cases are now handled gracefully, allowing the build to continue and providing clearer diagnostics. https://amd-hub.atlassian.net/browse/ROCM-1283 A real‑time package summary is now generated based on build status, improving visibility into which components succeeded, failed, or were skipped. Debian release metadata has been updated to include required hash fields (md5, sha256, etc.), ensuring compliance with Debian tooling expectations. Additionally, the large regenerate_repo_metadata_from_s3 function has been split into smaller deb/rpm‑specific functions for better maintainability and clearer separation of responsibilities. PRs cherry-picked as part of this PR: #3017 : Fix for packaging build failures due to missing artifactory #3059 : Prevent the uploading of .txt files to package repository #3006 : Fix for missing hash values like md5, sha256 in the Release file. --------- Co-authored-by: raramakr <raramakr@amd.com> Co-authored-by: nunnikri <71024015+nunnikri@users.noreply.github.com> Co-authored-by: Laura Promberger <laura.promberger@amd.com> Co-authored-by: Aravind Ravikumar <60629247+araravik-psd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Debian release file didnt had hash values like md5 sha256. The new change adds them to the release file. Also the big regenerate_repo_metadata_from_s3 fn has been split into deb/rpm smaller functions for better maintanance
Motivation
Latest Debian standards expect hash values like md5, sha256 in the Release file. Current release file didnt had hash values like md5 sha256. The new change adds them to the release file. Also the big regenerate_repo_metadata_from_s3 fn has been split into deb/rpm smaller functions for easier maintenance
Internal ticket tracking it ROCM-1331
Test Plan
The debian packages build shoudnt fail and setting up repo shouldnt show any warnings.
Test Result
Test run was success in https://github.com/ROCm/TheRock/actions/runs/21155463197/job/60839415580
Packages are available in https://rocm.devreleases.amd.com/deb/20260120-21085375476/dists/stable/index.html
With this repo setting is not showing any warnings.
Release file contents now has hash values:
https://rocm.devreleases.amd.com/deb/20260120-21085375476/dists/stable/Release