Skip to content

Enable architectures for libhipcxx (fixes #2504) #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obersteiner merged 1 commit into from
Feb 24, 2026
+0 −19
Merged

Enable architectures for libhipcxx (fixes #2504) #2946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions cmake/therock_amdgpu_targets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,10 @@ therock_add_amdgpu_target(gfx906 "Radeon VII / MI50 CDNA" FAMILY dgpu-all gfx90X
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
Copy link
Copy Markdown
Member

@marbre marbre Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are test failures for the so far tested gfx90a, see below. I assume this should be fixed before allowing to run on other gfx90X architectures?

)
therock_add_amdgpu_target(gfx908 "MI100 CDNA" FAMILY gfx90X-all dcgpu-all gfx90X-dcgpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx90a "MI210/250 CDNA" FAMILY gfx90X-all dcgpu-all gfx90X-dcgpu
EXCLUDE_TARGET_PROJECTS
Expand All @@ -73,23 +71,20 @@ therock_add_amdgpu_target(gfx1010 "AMD RX 5700" FAMILY dgpu-all gfx101X-all gfx1
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
Copy link
Copy Markdown
Member

@marbre marbre Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ROCm/TheRock/actions/runs/21752139280/job/63742765914?pr=2946#step:10:3072

[20](https://github.com/ROCm/TheRock/actions/runs/21752139280/job/63742765914?pr=2946#step:10:3025)
  5: Failed Tests (25):
  5:   libhip++ :: cuda/float/bfloat_cos_comparison.pass.cpp
  5:   libhip++ :: cuda/float/bfloat_exp_comparison.pass.cpp
  5:   libhip++ :: cuda/float/bfloat_log_comparison.pass.cpp
  5:   libhip++ :: cuda/float/bfloat_sin_comparison.pass.cpp
  5:   libhip++ :: cuda/float/bfloat_sqrt_comparison.pass.cpp
  5:   libhip++ :: cuda/float/half_cos_comparison.pass.cpp
  5:   libhip++ :: cuda/float/half_exp_comparison.pass.cpp
  5:   libhip++ :: cuda/float/half_log_comparison.pass.cpp
  5:   libhip++ :: cuda/float/half_sin_comparison.pass.cpp
  5:   libhip++ :: cuda/float/half_sqrt_comparison.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_cuda_float.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_cuda_generic.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_cuda_signed.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_cuda_unsigned.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_std_float.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_std_generic.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_std_signed.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/atomic_std_unsigned.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/flag.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/reference_cuda.pass.cpp
  5:   libhip++ :: heterogeneous/atomic/reference_std.pass.cpp
  5:   libhip++ :: heterogeneous/optional.pass.cpp
  5:   libhip++ :: heterogeneous/pair.pass.cpp
  5:   libhip++ :: heterogeneous/tuple.pass.cpp
  5:   libhip++ :: heterogeneous/variant.pass.cpp

Copy link
Copy Markdown
Member

@marbre marbre Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geomin12 @amd-justchen can you help looking into the potential node-issue? I think we should wait for a green signal and not fully rely on the local testing done by @obersteiner and team. We should make sure tests passed at least once before merging :)

Copy link
Copy Markdown
Contributor Author

@obersteiner obersteiner Feb 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geomin, @amd-justchen @marbre: In the logs I see errors like out of memory exceptions that I also see for example for thrust. We do not use a lot of memory in our tests (we do not have any large numeric tests but instead have only very small tests). An example for the rocThrust error https://github.com/ROCm/TheRock/actions/runs/21752139280/job/63742765864?pr=2946#step:10:19181

Copy link
Copy Markdown
Contributor Author

@obersteiner obersteiner Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are passing now.

)
therock_add_amdgpu_target(gfx1011 "AMD Radeon Pro V520" FAMILY dgpu-all gfx101X-all gfx101X-dgpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1012 "AMD RX 5500" FAMILY dgpu-all gfx101X-all gfx101X-dgpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
composable_kernel # https://github.com/ROCm/TheRock/issues/1245
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)

# gfx103X family
Expand All @@ -98,7 +93,6 @@ therock_add_amdgpu_target(gfx1030 "AMD RX 6800 / XT" FAMILY dgpu-all gfx103X-all
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1031 "AMD RX 6700 / XT" FAMILY dgpu-all gfx103X-all gfx103X-dgpu
EXCLUDE_TARGET_PROJECTS
Expand All @@ -111,7 +105,6 @@ therock_add_amdgpu_target(gfx1032 "AMD RX 6600" FAMILY dgpu-all gfx103X-all gfx1
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1033 "AMD Van Gogh iGPU" FAMILY igpu-all gfx103X-all gfx103X-igpu
EXCLUDE_TARGET_PROJECTS
Expand All @@ -131,75 +124,63 @@ therock_add_amdgpu_target(gfx1035 "AMD Radeon 680M Laptop iGPU" FAMILY igpu-all
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1036 "AMD Raphael iGPU" FAMILY igpu-all gfx103X-all gfx103X-igpu
EXCLUDE_TARGET_PROJECTS
hipBLASLt # https://github.com/ROCm/TheRock/issues/1062
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rocWMMA # https://github.com/ROCm/TheRock/issues/1944
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)

# gfx110X family
therock_add_amdgpu_target(gfx1100 "AMD RX 7900 XTX" FAMILY dgpu-all gfx110X-all gfx110X-dgpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1101 "AMD RX 7800 XT" FAMILY dgpu-all gfx110X-all gfx110X-dgpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1102 "AMD RX 7700S/Framework Laptop 16" FAMILY dgpu-all gfx110X-all gfx110X-dgpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1103 "AMD Radeon 780M Laptop iGPU" FAMILY igpu-all gfx110X-all gfx110X-igpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rccl # https://github.com/ROCm/TheRock/issues/150
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)

# gfx115X family
therock_add_amdgpu_target(gfx1150 "AMD Strix Point iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rccl # https://github.com/ROCm/TheRock/issues/150
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1151 "AMD Strix Halo iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rccl # https://github.com/ROCm/TheRock/issues/150
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1152 "AMD Krackan 1 iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rccl # https://github.com/ROCm/TheRock/issues/150
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1153 "AMD Radeon 820M iGPU" FAMILY igpu-all gfx115X-all gfx115X-igpu
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
rccl # https://github.com/ROCm/TheRock/issues/150
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)

# gfx120X family
therock_add_amdgpu_target(gfx1200 "AMD RX 9060 / XT" FAMILY dgpu-all gfx120X-all
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)
therock_add_amdgpu_target(gfx1201 "AMD RX 9070 / XT" FAMILY dgpu-all gfx120X-all
EXCLUDE_TARGET_PROJECTS
hipSPARSELt # https://github.com/ROCm/TheRock/issues/2042
libhipcxx # https://github.com/ROCm/TheRock/issues/2504
)

# Optional extension targets (used for out of tree target development).
Expand Down
Loading