You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @cjatin - I noticed this PR and #2001 both address enabling hip-tests on TheRock. PR #2001 was updated more recently (Jan 7), while this one hasn't had activity since it was opened.
Could you clarify which PR is the active effort? If #2001 is the main one, would you mind converting this PR to draft (or closing it) to reduce confusion? If this PR represents a different/simplified approach, happy to help get reviewers assigned.
Hi @cjatin - I noticed this PR and #2001 both address enabling hip-tests on TheRock. PR #2001 was updated more recently (Jan 7), while this one hasn't had activity since it was opened.
Could you clarify which PR is the active effort? If #2001 is the main one, would you mind converting this PR to draft (or closing it) to reduce confusion? If this PR represents a different/simplified approach, happy to help get reviewers assigned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co author: @agunashe
Motivation
Enable running hip-tests on TheRock CI.
Technical Details
Add scripts which shard/run the hip-tests in chunks of 4.
Test Plan
Since we are already building hip-tests on the TheRock, this patch should start running the tests.
Test Result
Passed locally, awaiting CI results.
Submission Checklist