Repository navigation
[rocwmma] Always build rocwmma with rocblas. - #2566
Merged
Merged
Conversation
We really don't have a reason right now to support all of the combinations and if disabled, tests run so slowly as to make them basically impossible to run. Fixes #2554
bsyrowik
reviewed
Dec 15, 2025
Collaborator
Author
|
PTAL - I think how I have it is right |
Collaborator
Author
|
@amd-shiraz RCCL tests on 942 timing out on every PR. Can you take it up in the stand-up tmw |
benrichard-amd
pushed a commit
to benrichard-amd/TheRock
that referenced
this pull request
Jan 5, 2026
We really don't have a reason right now to support all of the combinations and if disabled, tests run so slowly as to make them basically impossible to run. Fixes ROCm#2554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We really don't have a reason right now to support all of the combinations and if disabled, tests run so slowly as to make them basically impossible to run.
Fixes #2554