Repository navigation
Initial dependabot automation for bump of rocm-systems #2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
13236c2
89e4243
5b94886
f8f218e
07f0b53
3eeda77
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,3 +10,15 @@ updates: | |
| github-actions: | ||
| patterns: | ||
| - "*" | ||
| - package-ecosystem: "gitsubmodule" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, can we use a We can line that up with what #2401 will do for rocm-libraries. I think we should trigger sometime overnight PST so when developers start their workday they will have a bump PR ready to review with builds/tests completed already. Maybe 2AM? 11PM? open to suggestions... |
||
| target-branch: "main" | ||
| allow: | ||
| - dependency-name: "rocm-systems" | ||
| reviewers: | ||
| - "ScottTodd" | ||
| - "marbre" | ||
| - "geomin12" | ||
|
Comment on lines
+22
to
+25
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copying some comments from #2252 (comment)
We do have https://github.com/orgs/ROCm/teams/therockinfra available, with 19 members right now. That's maybe too wide a group in my opinion (as responsibility then gets diffused too much and everyone on the list assumes someone else will review). I would prefer to have an automated rotation with ~2 members active at a time, cycling once week or so.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh... |
||
| open-pull-requests-limit: 10 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to include the date in the commit message and PR title, but I don't see a way to do that: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#commit-message--
(I'm seeing how consistent with #2401)