Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,15 @@ updates:
github-actions:
patterns:
- "*"
- package-ecosystem: "gitsubmodule"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to include the date in the commit message and PR title, but I don't see a way to do that: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#commit-message--

(I'm seeing how consistent with #2401)

directory: "/"
schedule:
interval: "daily"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can we use a cronjob schedule instead of this "daily interval"?
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#interval

We can line that up with what #2401 will do for rocm-libraries.

I think we should trigger sometime overnight PST so when developers start their workday they will have a bump PR ready to review with builds/tests completed already. Maybe 2AM? 11PM? open to suggestions...

target-branch: "main"
allow:
- dependency-name: "rocm-systems"
reviewers:
- "ScottTodd"
- "marbre"
- "geomin12"
Comment on lines +22 to +25

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying some comments from #2252 (comment)

Fine to start as you have this now, but we should add a github team or some labels to help with review, rather than tag individual maintainers like this.

Agree on having this reviewers centralized. we can have two approach:

  1. move reviewers field outside to some CODEOWNERS.yaml and maintain it there in code.
  2. low hanging would be to have teams setup in github as suggested by @ScottTodd

We do have https://github.com/orgs/ROCm/teams/therockinfra available, with 19 members right now. That's maybe too wide a group in my opinion (as responsibility then gets diffused too much and everyone on the list assumes someone else will review). I would prefer to have an automated rotation with ~2 members active at a time, cycling once week or so.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open-pull-requests-limit: 10
Loading