Skip to content

Conversation

@ammallya
Copy link
Contributor

Rebasing PR #2184 to solve merge conflict.

All CI tests passed including re run of previously failed rccl.

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title does not make sense. There was a merge conflict on #2184. That could have been resolved on that PR. Fine to start a new PR for a new update, but there is no need to mention a "submodule conflict" here.

@ammallya ammallya changed the title Resolve submodule conflict rocm-libraries 20251118 Submodule bump rocm-libraries 20251118 Nov 19, 2025
@ammallya
Copy link
Contributor Author

The PR title does not make sense. There was a merge conflict on #2184. That could have been resolved on that PR. Fine to start a new PR for a new update, but there is no need to mention a "submodule conflict" here.

That makes sense I fixed the title

@ammallya ammallya requested a review from ScottTodd November 19, 2025 16:40
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing test timeouts in hipsparselt, rccl, and rocwmma. I think those aren't new...

@ammallya ammallya merged commit 771281b into main Nov 19, 2025
80 of 85 checks passed
@ammallya ammallya deleted the ammallya/rocm-libraries-20251118-resolved branch November 19, 2025 17:02
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants