Add Replace, Conflicts, Recommends, Provides and Suggests metadata handling in RPM and Debian packaging #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raramakr
requested review from
ScottTodd,
frepaul,
marbre,
nunnikri and
stellaraccident
and removed request for
ScottTodd
ScottTodd
approved these changes
Nov 20, 2025
Comment on lines
+89
to
+90
| # Clean debian build directory | ||
| remove_dir(DEBIAN_CONTENTS_DIR) |
Member
There was a problem hiding this comment.
Oh, I'm just noticing that this is a global variable... you could move it into a local variable that gets passed into each function for better encapsulation.
https://google.github.io/styleguide/pyguide.html#25-mutable-global-state
This looks dangerous since it isn't clear where the variable gets set to a valid directory and this is a destructive operation.
Contributor
Author
There was a problem hiding this comment.
This is on our radar and we are making these changes (global to local variable)for the next patch
Contributor
Author
…ndling in RPM and Debian packaging Refactor: Handle directory removal logic(cleaning of build directories) in one function
raramakr
force-pushed
the
users/raramakr/native-pkg
branch
from
1d1c5b8 to
534ed84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields are required for handling more use cases
Refactor: Handle directory removal logic(cleaning of build directories) in one function