-
Notifications
You must be signed in to change notification settings - Fork 130
Enabling native packging workflow in daily Release build. #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
geomin12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks great! just a few comments for housekeeping and for structural curiosity
ScottTodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks about right, thanks. The build graph sequencing is a concern though... I still need to finish the refactoring that will let us slot these pipelines together more naturally somehow.
…h workflow_dispatch instead of workflow_call
ScottTodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
We may want to add a status badge for https://github.com/ROCm/TheRock/actions/workflows/build_native_linux_packages.yml here: https://github.com/ROCm/TheRock/blob/main/README.md#nightly-release-status
We'll also want a section on "Installing native Linux packages" here at some point: https://github.com/ROCm/TheRock/blob/main/RELEASES.md .
We can start with some disclaimers like "these are not yet ready for general consumption" until the S3 buckets are fully configured with release channels and we've validated these packages further.
Motivation
Enabling native packaging workflow in daily Release build. This will enable users to access to rpm and debian packages for daily builds.
Technical Details
Test Plan
The code is unit tested using python scripts invocation. And integration testing using github worflow run from the branch
The full build job : https://github.com/ROCm/TheRock/actions/runs/19488211687
Submission Checklist