Skip to content

Conversation

@nunnikri
Copy link
Contributor

@nunnikri nunnikri commented Nov 14, 2025

Motivation

Enabling native packaging workflow in daily Release build. This will enable users to access to rpm and debian packages for daily builds.

Technical Details

  • Invoking reusable workflow build_native_linux_packages.yml through workflow_call method from daily release build workflow release_portable_linux_packages.yml
  • Share the build artifacts bw two workflow using github artifacts upload-artifact and download-artifact actions
  • Upload the rpm/debian packages to temporary aws bucket therock-deb-rpm-test

Test Plan

The code is unit tested using python scripts invocation. And integration testing using github worflow run from the branch
The full build job : https://github.com/ROCm/TheRock/actions/runs/19488211687

Submission Checklist

@nunnikri nunnikri marked this pull request as draft November 14, 2025 18:11
@nunnikri nunnikri marked this pull request as ready for review November 15, 2025 00:56
Copy link
Contributor

@geomin12 geomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great! just a few comments for housekeeping and for structural curiosity

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks about right, thanks. The build graph sequencing is a concern though... I still need to finish the refactoring that will let us slot these pipelines together more naturally somehow.

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

We may want to add a status badge for https://github.com/ROCm/TheRock/actions/workflows/build_native_linux_packages.yml here: https://github.com/ROCm/TheRock/blob/main/README.md#nightly-release-status

We'll also want a section on "Installing native Linux packages" here at some point: https://github.com/ROCm/TheRock/blob/main/RELEASES.md .

We can start with some disclaimers like "these are not yet ready for general consumption" until the S3 buckets are fully configured with release channels and we've validated these packages further.

@nunnikri nunnikri merged commit c59f2e8 into main Nov 21, 2025
150 of 163 checks passed
@nunnikri nunnikri deleted the users/nunnikri/native_daiy_release_workflow branch November 21, 2025 22:18
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants