To keep the nightly configuration overwrite pre-submit configuration#2123
Merged
Conversation
Signed-off-by: Liao <dezhliao@amd.com>
Signed-off-by: dezhliao <dezhliao@amd.com>
dezhiAmd
changed the title
1 task
dezhiAmd
changed the title
dezhiAmd
requested review from
HereThereBeDragons,
ScottTodd,
amd-justchen and
marbre
amd-justchen
approved these changes
Nov 13, 2025
Contributor
amd-justchen
left a comment
amd-justchen
left a comment
There was a problem hiding this comment.
The tests seem to be good!
rponnuru5
pushed a commit
that referenced
this pull request
Dec 9, 2025
…2123) Fix PR builds to incorrectly use nightly configurations. Signed-off-by: Liao <dezhliao@amd.com> Signed-off-by: dezhliao <dezhliao@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The original code had a critical bug: when a gfx family appeared in multiple trigger types (e.g., gfx110x in both presubmit and nightly), its configuration was overwritten due to Python’s dictionary merge operator (|).
This caused:
See related issue: #1097
Technical Details
Introduced a new function get_all_families_for_trigger_types() to replace amdgpu_family_info_matrix_all.
Key changes:
Test Plan
After the change, tests runs on runner "windows-gfx110X-gpu-rocm" with gfx family gfx110X-dgpu only happens nightly, not pre-submit
Test Result
Test pass
Submission Checklist