Skip to content

Fixed missing glob_c_sources(hipCUB...)#2099

Merged
marbre merged 1 commit into
ROCm:mainfrom
umarinkovic:fix/glob_hipCUB
Nov 12, 2025
Merged

Fixed missing glob_c_sources(hipCUB...)#2099
marbre merged 1 commit into
ROCm:mainfrom
umarinkovic:fix/glob_hipCUB

Conversation

@umarinkovic
Copy link
Copy Markdown
Contributor

Motivation

Fixes missing therock_cmake_subrpoject_glob_c_sources call for hipCUB (was referencing rocPRIM for the second time instead)

Submission Checklist

@umarinkovic
Copy link
Copy Markdown
Contributor Author

umarinkovic commented Nov 12, 2025

This looked wrong to me, sorry to clutter the triage if I am mistaken.

Copy link
Copy Markdown
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! This indeed seems like a copy paste error.

@umarinkovic
Copy link
Copy Markdown
Contributor Author

Good catch, thanks! This indeed seems like a copy paste error.

Thanks! If you don't mind me asking, how were hipCUB or its tests being compiled/installed without this glob call? Is there another mechanism for setting the source files that was being used that has led to this going unnoticed?

@marbre
Copy link
Copy Markdown
Member

marbre commented Nov 12, 2025

Good catch, thanks! This indeed seems like a copy paste error.

Thanks! If you don't mind me asking, how were hipCUB or its tests being compiled/installed without this glob call? Is there another mechanism for setting the source files that was being used that has led to this going unnoticed?

Actually idk without digging further.

Test / build failures are unrelated and due to a configuration change in our bucket permissions (fixed this in the background a minute ago), thus this is fine to land without waiting for further (failing) tests.

@marbre marbre merged commit 067a232 into ROCm:main Nov 12, 2025
8 of 9 checks passed
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Nov 12, 2025
@umarinkovic umarinkovic deleted the fix/glob_hipCUB branch November 12, 2025 15:47
rponnuru5 pushed a commit that referenced this pull request Dec 9, 2025
## Motivation

Fixes missing `therock_cmake_subrpoject_glob_c_sources` call for hipCUB
(was referencing rocPRIM for the second time instead)

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants