Fixed missing glob_c_sources(hipCUB...)#2099
Conversation
|
This looked wrong to me, sorry to clutter the triage if I am mistaken. |
marbre
left a comment
There was a problem hiding this comment.
Good catch, thanks! This indeed seems like a copy paste error.
Thanks! If you don't mind me asking, how were hipCUB or its tests being compiled/installed without this glob call? Is there another mechanism for setting the source files that was being used that has led to this going unnoticed? |
Actually idk without digging further. Test / build failures are unrelated and due to a configuration change in our bucket permissions (fixed this in the background a minute ago), thus this is fine to land without waiting for further (failing) tests. |
## Motivation Fixes missing `therock_cmake_subrpoject_glob_c_sources` call for hipCUB (was referencing rocPRIM for the second time instead) ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Motivation
Fixes missing
therock_cmake_subrpoject_glob_c_sourcescall for hipCUB (was referencing rocPRIM for the second time instead)Submission Checklist