Skip to content

Adding attributes to release workflows #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
araravik-psd merged 2 commits into from
Aug 29, 2025
Merged

Adding attributes to release workflows #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1206f00
Adding attributes to release workflows
aravind-ravi1206 Aug 28, 2025
621d936
Removing trailing quote
aravind-ravi1206 Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/release_portable_linux_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ on:
package_suffix:
type: string
s3_subdir:
description: "Subdirectory to push the Python packages"
description: "Subdirectory to push the packages"
type: string
default: "v2"
s3_staging_subdir:
description: "Staging subdirectory to push the Python packages"
description: "Staging subdirectory to push the packages"
type: string
default: "v2-staging"
# Trigger manually (typically to test the workflow or manually build a release [candidate])
Expand All @@ -28,11 +28,11 @@ on:
package_suffix:
type: string
s3_subdir:
description: "Subdirectory to push the Python packages"
description: "Subdirectory to push the packages"
type: string
default: "v2"
s3_staging_subdir:
description: "Staging subdirectory to push the Python packages"
description: "Staging subdirectory to push the packages"
type: string
default: "v2-staging"
families:
Expand All @@ -59,6 +59,7 @@ jobs:
release_type: ${{ env.release_type }}
package_targets: ${{ steps.configure.outputs.package_targets }}
cloudfront_url: ${{ steps.release_information.outputs.cloudfront_url }}
cloudfront_staging_url: ${{ steps.release_information.outputs.cloudfront_staging_url }}
steps:
- name: Checkout repository
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
Expand Down Expand Up @@ -88,6 +89,7 @@ jobs:
base_version=$(jq -r '.["rocm-version"]' version.json)
echo "version=${base_version}${version_suffix}" >> $GITHUB_OUTPUT
echo "cloudfront_url=${cloudfront_base_url}/${{ env.S3_SUBDIR }}" >> $GITHUB_OUTPUT
echo "cloudfront_staging_url=${cloudfront_base_url}/${{ env.S3_STAGING_SUBDIR }}" >> $GITHUB_OUTPUT

- name: Generating package target matrix
id: configure
Expand Down Expand Up @@ -239,7 +241,9 @@ jobs:
{ "amdgpu_family": "${{ matrix.target_bundle.amdgpu_family }}",
"release_type": "${{ env.RELEASE_TYPE }}",
"s3_subdir": "${{ env.S3_SUBDIR }}",
"s3_staging_subdir": "${{ env.S3_STAGING_SUBDIR }}",
"cloudfront_url": "${{ needs.setup_metadata.outputs.cloudfront_url }}",
"cloudfront_staging_url": "${{ needs.setup_metadata.outputs.cloudfront_staging_url }}",
"rocm_version": "${{ needs.setup_metadata.outputs.version }}"
}

Expand Down
20 changes: 19 additions & 1 deletion .github/workflows/release_portable_linux_pytorch_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,18 @@ on:
description: S3 subdirectory, not including the GPU-family
type: string
default: "v2"
s3_staging_subdir:
description: Staging subdirectory to push the wheels for test
type: string
default: "v2-staging"
cloudfront_url:
description: CloudFront URL pointing to Python index
required: true
type: string
cloudfront_staging_url:
description: CloudFront base URL pointing to staging Python index
required: true
type: string
default: "https://d25kgig7rdsyks.cloudfront.net/v2"
rocm_version:
description: ROCm version to pip install
type: string
Expand All @@ -40,10 +48,18 @@ on:
description: S3 subdirectory, not including the GPU-family
type: string
default: "v2"
s3_staging_subdir:
description: "Staging subdirectory to push the wheels for test"
type: string
default: "v2-staging"
cloudfront_url:
description: CloudFront URL pointing to Python index
type: string
default: "https://d25kgig7rdsyks.cloudfront.net/v2"
cloudfront_staging_url:
description: CloudFront base URL pointing to staging Python index
type: string
default: "https://d25kgig7rdsyks.cloudfront.net/v2-staging"
rocm_version:
description: ROCm version to pip install
type: string
Expand Down Expand Up @@ -73,7 +89,9 @@ jobs:
python_version: ${{ matrix.python_version }}
release_type: ${{ inputs.release_type }}
s3_subdir: ${{ inputs.s3_subdir }}
s3_staging_subdir: ${{ inputs.s3_staging_subdir }}
cloudfront_url: ${{ inputs.cloudfront_url }}
cloudfront_staging_url: ${{ inputs.cloudfront_staging_url }}
rocm_version: ${{ inputs.rocm_version }}
pytorch_version: ${{ matrix.pytorch_version }}
pytorch_patchset: ${{ matrix.pytorch_patchset }}
Loading