Skip to content

[ci] Add merge_matrices function to amdgpu_family_matrix.#1350

Closed
ScottTodd wants to merge 1 commit into
ROCm:mainfrom
ScottTodd:family-matrix-merging
Closed

[ci] Add merge_matrices function to amdgpu_family_matrix.#1350
ScottTodd wants to merge 1 commit into
ROCm:mainfrom
ScottTodd:family-matrix-merging

Conversation

@ScottTodd
Copy link
Copy Markdown
Member

Sending for consideration... I think some other structure in this file would be less error prone than this (see #1097).

I was considering making Windows build/test gfx115x on presubmit while keeping Linux gfx115x on postsubmit as part of #1349.

  • Without a change like this, we have to include both platforms in the same category, since the dictionary merging using (amdgpu_family_info_matrix_presubmit | amdgpu_family_info_matrix_postsubmit) would overwrite the gfx115x entry.
  • With this change, presubmit and postsubmit can both have entries for a given architecture (e.g. Linux gfx115x postsubmit and Windows gfx115x presubmit).

This allows for presubmit and postsubmit to both have entries for a given architecture (e.g. Linux gfx115x postsubmit and Windows gfx115x presubmit).
@ScottTodd
Copy link
Copy Markdown
Member Author

Merge conflicts, might retry something like this again later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant