Drop rocPRIM patch#1345
Merged
Merged
Conversation
stanleytsang-amd
approved these changes
Aug 28, 2025
Member
Author
We previously had a build failure, so it should be fine to land it as is but with what is currently going on I'd prefer to land after we're green again on Windows. That would at least give us a signal on post-submit and I could revert and bring it back if needed but to me it seems that we're fine without it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch was needed prior to ROCm/rocm-libraries#1029. With the fixes to upstream, the local patch is no longer needed.