Skip to content

Bump rocm-libraries submodule 20250828 #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marbre merged 14 commits into from
Sep 2, 2025
Merged

Bump rocm-libraries submodule 20250828 #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c1d97a4
Bump math-libs, ml-libs and rocm-libraries submodules 20250812
marbre Aug 12, 2025
cdc7f81
Bump rocm-libraries submodule 20250818
marbre Aug 25, 2025
dc93ecb
Rebase patch to find LAPACK and CBLAS
marbre Aug 26, 2025
5d4c325
Rebase patch to install lihipblas_fortran
marbre Aug 26, 2025
e5fbf6f
Drop patch to work around race condition
marbre Aug 26, 2025
aa1015f
Bump rocm-libraries submodule 20250826
marbre Aug 26, 2025
e980f5d
Drop obsolete patch
marbre Aug 26, 2025
d2cd9a8
Use new hipblaslt build system
marbre Aug 26, 2025
c196b6b
Take over patch
marbre Aug 26, 2025
be4b1b4
Add patch to temporarily revert
marbre Aug 26, 2025
aabb959
Bump submodules 20250826
marbre Aug 26, 2025
f2698fd
Bump submodules 20250827
marbre Aug 27, 2025
cbad05e
Add patch to temporarily revert
marbre Aug 27, 2025
1e527cc
Bump submodules 20250827
marbre Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions math-libs/BLAS/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,13 @@ therock_cmake_subproject_declare(hipBLASLt
EXTERNAL_SOURCE_DIR "${THEROCK_ROCM_LIBRARIES_SOURCE_DIR}/projects/hipblaslt"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/hipBLASLt"
BACKGROUND_BUILD
CMAKE_LISTS_RELPATH "next-cmake"
CMAKE_ARGS
-DHIP_PLATFORM=amd
-DHIPBLASLT_ENABLE_BLIS=OFF # TODO: Evaluate
-DBUILD_TESTING=${THEROCK_BUILD_TESTING}
-DTENSILELITE_BUILD_TESTING=OFF
-DHIPBLASLT_BUILD_TESTING=${THEROCK_BUILD_TESTING}
-DHIPBLASLT_ENABLE_ROCROLLER=${_enable_rocRoller}
-DHIPBLASLT_ENABLE_FETCH=OFF
CMAKE_INCLUDES
therock_explicit_finders.cmake
COMPILER_TOOLCHAIN
Expand Down
2 changes: 1 addition & 1 deletion math-libs/BLAS/hipSOLVER
Open in desktop
Submodule hipSOLVER updated 25 files
+1 −0 .jenkins/common.groovy
+17 −0 CHANGELOG.md
+53 −32 CMakeLists.txt
+4 −4 bump_hipsolver_version.sh
+6 −1 clients/gtest/CMakeLists.txt
+33 −1 clients/gtest/gebrd_gtest.cpp
+52 −1 clients/gtest/gesvdj_gtest.cpp
+45 −1 clients/gtest/orgbr_ungbr_gtest.cpp
+45 −1 clients/gtest/orgqr_ungqr_gtest.cpp
+45 −1 clients/gtest/orgtr_ungtr_gtest.cpp
+45 −1 clients/gtest/ormqr_unmqr_gtest.cpp
+45 −1 clients/gtest/ormtr_unmtr_gtest.cpp
+33 −1 clients/gtest/potri_gtest.cpp
+45 −1 clients/gtest/syevd_heevd_gtest.cpp
+45 −1 clients/gtest/syevdx_heevdx_gtest.cpp
+65 −1 clients/gtest/syevj_heevj_gtest.cpp
+45 −1 clients/gtest/sygvd_hegvd_gtest.cpp
+45 −1 clients/gtest/sygvdx_hegvdx_gtest.cpp
+45 −1 clients/gtest/sygvj_hegvj_gtest.cpp
+45 −1 clients/gtest/sytrd_hetrd_gtest.cpp
+33 −1 clients/gtest/sytrf_gtest.cpp
+454 −0 clients/include/hipsolver.hpp
+1 −1 docs/installation/install.rst
+1 −1 install.sh
+41 −0 library/src/CMakeLists.txt
2 changes: 1 addition & 1 deletion math-libs/BLAS/rocSOLVER
Open in desktop
Submodule rocSOLVER updated 18 files
+6 −0 CHANGELOG.md
+441 −32 clients/common/auxiliary/testing_stedc.hpp
+362 −34 clients/common/lapack/testing_syevd_heevd.hpp
+4 −7 library/src/auxiliary/rocauxiliary_larf.hpp
+5 −8 library/src/auxiliary/rocauxiliary_larfg.hpp
+3 −6 library/src/auxiliary/rocauxiliary_larft.hpp
+1,995 −1,796 library/src/auxiliary/rocauxiliary_stedc.hpp
+1 −1 library/src/auxiliary/rocauxiliary_stedcj.cpp
+1,309 −36 library/src/auxiliary/rocauxiliary_stedcj.hpp
+1,336 −33 library/src/auxiliary/rocauxiliary_stedcx.hpp
+5 −9 library/src/auxiliary/rocauxiliary_steqr.hpp
+675 −0 library/src/include/lapack_device_functions.hpp
+2 −0 library/src/include/lib_device_helpers.hpp
+140 −1 library/src/lapack/roclapack_geqr2.hpp
+5 −8 library/src/lapack/roclapack_gesdd.hpp
+33 −0 library/src/lapack/roclapack_syevd_heevd.hpp
+13 −8 library/src/lapack/roclapack_sytd2_hetd2.hpp
+3 −6 library/src/specialized/roclapack_gemm_specialized_kernels.hpp
2 changes: 1 addition & 1 deletion ml-libs/composable_kernel
Open in desktop
Submodule composable_kernel updated 951 files
199 changes: 0 additions & 199 deletions ...d-mainline/rocm-libraries/0002-Fix-linkage-for-tensilelite-host-target-and-bump-mxd.patch
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions ...d-mainline/rocm-libraries/0010-Correct-GTest-print-check-for-128-bit-ints-on-Window.patch
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions patches/amd-mainline/rocm-libraries/0011-Fix-finding-LAPACK-and-CBLAS.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
From c194b05d6b1fb98da896784c580ecba5c36b1297 Mon Sep 17 00:00:00 2001
From fa6af5c20b2d3700c3570ac8c4c5fea02e21e781 Mon Sep 17 00:00:00 2001
From: Marius Brehler <marius.brehler@amd.com>
Date: Tue, 25 Mar 2025 12:13:13 +0000
Subject: [PATCH 11/17] Fix finding LAPACK and CBLAS
Date: Tue, 26 Aug 2025 10:09:28 +0000
Subject: [PATCH] Fix finding LAPACK and CBLAS

Use target names provided by `find_package()` instead of assuming that
the reference NETLIB libraries should be used.
Expand All @@ -10,7 +10,7 @@ the reference NETLIB libraries should be used.
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/projects/hipblas/clients/CMakeLists.txt b/projects/hipblas/clients/CMakeLists.txt
index a230135a10..b5e4eb0fb6 100644
index 4ba4e950c9..6863e7c080 100644
--- a/projects/hipblas/clients/CMakeLists.txt
+++ b/projects/hipblas/clients/CMakeLists.txt
@@ -28,8 +28,8 @@ function( get_lapack lapack_lib lapack_inc )
Expand All @@ -33,15 +33,15 @@ index a230135a10..b5e4eb0fb6 100644
endif()
endif()
set( ${cblas_libs} ${libs} PARENT_SCOPE )
@@ -221,7 +221,7 @@ if( BUILD_CLIENTS_BENCHMARKS OR BUILD_CLIENTS_TESTS)
@@ -236,7 +236,7 @@ if( BUILD_CLIENTS_BENCHMARKS OR BUILD_CLIENTS_TESTS)
find_package( GTest REQUIRED )

message(STATUS "Build Dir: ${BUILD_DIR}")
- message(STATUS "Linking Ref. Libs: ${BLAS_LIBRARY}")
+ message(STATUS "Linking Libs: ${BLAS_LIBRARY}")

if( BUILD_CLIENTS_TESTS )
add_subdirectory( gtest )
if( NOT TARGET hipblas )
find_package( hipblas REQUIRED CONFIG PATHS ${HIPBLAS_LIBRARY_DIR} )
--
2.43.0

32 changes: 0 additions & 32 deletions patches/amd-mainline/rocm-libraries/0012-Work-around-race-condition.patch
View file
Open in desktop

This file was deleted.

30 changes: 15 additions & 15 deletions patches/amd-mainline/rocm-libraries/0013-Install-libhipblas_fortran.so.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
From 7e26c6c64ba19d9a7d6dcb736aba374407df0673 Mon Sep 17 00:00:00 2001
From 20d3866866edae3398861692e2af98f4814f8010 Mon Sep 17 00:00:00 2001
From: Marius Brehler <marius.brehler@amd.com>
Date: Tue, 1 Apr 2025 20:58:38 +0000
Subject: [PATCH 13/17] Install `libhipblas_fortran.so`
Date: Tue, 26 Aug 2025 10:15:45 +0000
Subject: [PATCH] Install `libhipblas_fortran.so`

This is required by the test and benchmark clients but was not part of
the installation so far.
---
projects/hipblas/library/src/CMakeLists.txt | 1 +
projects/hipblas/clients/CMakeLists.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/projects/hipblas/library/src/CMakeLists.txt b/projects/hipblas/library/src/CMakeLists.txt
index 7318e3fd88..8846fec9d3 100755
--- a/projects/hipblas/library/src/CMakeLists.txt
+++ b/projects/hipblas/library/src/CMakeLists.txt
@@ -54,6 +54,7 @@ set (hipblas_f90_source
# Create hipBLAS Fortran module
if(NOT WIN32)
add_library(hipblas_fortran ${hipblas_f90_source})
+ rocm_install(TARGETS hipblas_fortran)
endif()
diff --git a/projects/hipblas/clients/CMakeLists.txt b/projects/hipblas/clients/CMakeLists.txt
index 4ba4e950c9..e17ce117d2 100644
--- a/projects/hipblas/clients/CMakeLists.txt
+++ b/projects/hipblas/clients/CMakeLists.txt
@@ -121,6 +121,7 @@ if( BUILD_CLIENTS_TESTS OR BUILD_CLIENTS_BENCHMARKS OR BUILD_CLIENTS_SAMPLES )
# Set Fortran module output directory
set(CMAKE_Fortran_MODULE_DIRECTORY ${PROJECT_BINARY_DIR}/include/hipblas)
add_library(hipblas_fortran OBJECT ${hipblas_f90_source})
+ rocm_install(TARGETS hipblas_fortran)
endif()

if(BUILD_ADDRESS_SANITIZER)
if( NOT WIN32 )
--
2.43.0

Loading
Loading