Skip to content

Update docs and scripts after repo to submodules migration. - #129

Merged
ScottTodd merged 2 commits into
ROCm:mainfrom
ScottTodd:sources-cleanup
Mar 3, 2025
Merged

ScottTodd merged 2 commits into
ROCm:mainfrom
ScottTodd:sources-cleanup

Conversation

@ScottTodd

Copy link
Copy Markdown
Member

Follow-up to #128.

  • Drop some references to 'repo' and the 'sources/' directory
  • Change Windows instructions from requiring symlinks to just recommending them
  • Drop repo-specific configuration from Windows workflow

@ScottTodd

Copy link
Copy Markdown
Member Author

Linux had an error in configure-aws-credentials:
https://github.com/nod-ai/TheRock/actions/runs/13639266673/job/38125168755?pr=129#step:11:13

It looks like you might be trying to authenticate with OIDC. Did you mean to set the `id-token` permission? If you are not trying to authenticate with OIDC and the action is working successfully, you can ignore this message.
Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

fyi @marbre

@ScottTodd
ScottTodd marked this pull request as ready for review March 3, 2025 21:04
@marbre

marbre commented Mar 3, 2025

Copy link
Copy Markdown
Member

Linux had an error in configure-aws-credentials: https://github.com/nod-ai/TheRock/actions/runs/13639266673/job/38125168755?pr=129#step:11:13

It looks like you might be trying to authenticate with OIDC. Did you mean to set the `id-token` permission? If you are not trying to authenticate with OIDC and the action is working successfully, you can ignore this message.
Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

fyi @marbre

😞 I take a look.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, clean repo checkout + fetch sources + configure + build on Windows results in a dirty submodule for core/HIP:

D:\projects\TheRock\core\HIP (HEAD detached at 5b39b76)
λ git diff
diff --git a/VERSION b/VERSION
index 8145569e..5d77842a 100644
--- a/VERSION
+++ b/VERSION
@@ -1,6 +1,3 @@
-#HIP_VERSION_MAJOR
 6
-#HIP_VERSION_MINOR
 4
-#HIP_VERSION_PATCH
-43480
+0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, it's been a TODO since the very beginning to deal with that HIP version pin nonsense. It's nonsense upstream...

@ScottTodd

Copy link
Copy Markdown
Member Author

Linux had an error in configure-aws-credentials: https://github.com/nod-ai/TheRock/actions/runs/13639266673/job/38125168755?pr=129#step:11:13

It looks like you might be trying to authenticate with OIDC. Did you mean to set the `id-token` permission? If you are not trying to authenticate with OIDC and the action is working successfully, you can ignore this message.
Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

fyi @marbre

😞 I take a look.

Maybe because this PR comes from a fork?

@marbre

marbre commented Mar 3, 2025 •

Copy link
Copy Markdown
Member

Linux had an error in configure-aws-credentials: https://github.com/nod-ai/TheRock/actions/runs/13639266673/job/38125168755?pr=129#step:11:13

It looks like you might be trying to authenticate with OIDC. Did you mean to set the `id-token` permission? If you are not trying to authenticate with OIDC and the action is working successfully, you can ignore this message.
Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

fyi @marbre

😞 I take a look.

Maybe because this PR comes from a fork?

Yes, the role-to-assume is only accessible from within our repo and not from any forks. I have a workaround for skipping the upload in that case but haven't pushed it yet. Thus, the failure can be ignored for now.

Comment on lines -80 to -86
- name: Install Certs
run: python -m pip install certifi

- name: Fetch sources
run: |
# Sets an env variable to ensure urllib uses the certifi CA bundle in fetch_sources.py.
export SSL_CERT_FILE=$(python3 -m certifi)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amd-chrissosa @Eliasj42 FYI no more certificate setup needed in here now that we use git submodules instead of repo

@ScottTodd
ScottTodd merged commit 5d3a8e4 into ROCm:main Mar 3, 2025
@ScottTodd
ScottTodd deleted the sources-cleanup branch March 3, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants