Repository navigation
Update docs and scripts after repo to submodules migration. - #129
Conversation
|
Linux had an error in configure-aws-credentials: fyi @marbre |
😞 I take a look. |
There was a problem hiding this comment.
Hm, clean repo checkout + fetch sources + configure + build on Windows results in a dirty submodule for core/HIP:
D:\projects\TheRock\core\HIP (HEAD detached at 5b39b76)
λ git diff
diff --git a/VERSION b/VERSION
index 8145569e..5d77842a 100644
--- a/VERSION
+++ b/VERSION
@@ -1,6 +1,3 @@
-#HIP_VERSION_MAJOR
6
-#HIP_VERSION_MINOR
4
-#HIP_VERSION_PATCH
-43480
+0There was a problem hiding this comment.
Ugh, it's been a TODO since the very beginning to deal with that HIP version pin nonsense. It's nonsense upstream...
Maybe because this PR comes from a fork? |
Yes, the |
| - name: Install Certs | ||
| run: python -m pip install certifi | ||
|
|
||
| - name: Fetch sources | ||
| run: | | ||
| # Sets an env variable to ensure urllib uses the certifi CA bundle in fetch_sources.py. | ||
| export SSL_CERT_FILE=$(python3 -m certifi) |
There was a problem hiding this comment.
@amd-chrissosa @Eliasj42 FYI no more certificate setup needed in here now that we use git submodules instead of repo
Follow-up to #128.