Decouple free ab#678
Merged
Merged
Conversation
- allow strides < minStrides to be specified - compute m_totalAllocatedElements to gracefully handle alternate strides
- pass setConstStride overloads to tensile-client in non-GEMM mode too - set defaults ld* to -1 not 0
- add UseDefaultStride to class - dimensionPadding return int64_t since can be <0 - whitespace
- use proper totalAllocatedElements formula for strides - add a few tests for zero strides, simple padding, and strides<size
- allow A and B to have different # free indices - modify python and C++ data structures to track FreeIndex with 'isA' field (rather than a combo that required free index be in both A and B) - replace freeSizes() with freeSizesA() and freeSizesB()
sdquiring
approved these changes
Sep 30, 2019
| m_freeSizeB[i] = std::max({m_b.sizes()[m_freeIndices[i].b], | ||
| m_c.empty() ? 0 : m_c.sizes()[m_freeIndices[i].cb], | ||
| m_d.sizes()[m_freeIndices[i].db]}); | ||
| size_t maxSize=0; // TODO - aren't these all the same? |
Contributor
There was a problem hiding this comment.
What do you mean by this?
Contributor
Author
There was a problem hiding this comment.
I believe each dimension has same size across A/B/C/D tensors. So not clear why we need the max ? Can just read it from D, and if desired double-check that size in A or B is the same?
saadrahim
pushed a commit
to saadrahim/Tensile
that referenced
this pull request
Oct 3, 2019
* Use a similar method as in rocBLAS to determine whether to use C++ and HIP features in tensile_bfloat16.h * Make bfloat16 changes similar to rocBLAS PR ROCm#678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.