Repository navigation
Remove xfail on fixed hpa_source tests - #1617
Merged
Merged
Conversation
Contributor
|
The change looks OK. |
Collaborator
Author
|
The test failure was due to a compiler bug introduced in rocm 5.3. The test was marked xfail until a compiler update was ready. The current rocm build on CI has the fix in it, but CI is soon moving to another build that does not have the fix in it (so the test will again be expected to fail). We can merge this as soon as CI returns to a build with the patch (or sooner if we don't mind seeing a known test failure in builds) |
nakajee
approved these changes
Nov 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after CI rocm version updated