Repository navigation
handle clusters (alternative) - #287
Merged
Merged
Conversation
aktemur
force-pushed
the
users/aktemur/cluster-111
branch
from
September 22, 2026 08:47
7f5823a to
cc43daa
Compare
Contributor
Author
|
The force-push above is a rebase. |
aktemur
force-pushed
the
users/aktemur/cluster-111
branch
2 times, most recently
from
September 28, 2026 07:58
51fbc85 to
d08a951
Compare
lancesix
reviewed
Sep 28, 2026
aktemur
force-pushed
the
users/aktemur/cluster-111
branch
from
September 29, 2026 15:45
d08a951 to
35a15f6
Compare
Contributor
Author
|
The force-push above is a rebase. |
aktemur
force-pushed
the
users/aktemur/cluster-111
branch
from
September 29, 2026 16:35
35a15f6 to
a78e1c9
Compare
aktemur
force-pushed
the
users/aktemur/cluster-111
branch
from
October 5, 2026 07:44
a78e1c9 to
621e132
Compare
Contributor
Author
|
CHANGELOG needs to be updated, too. |
lancesix
approved these changes
Oct 6, 2026
lancesix
left a comment
lancesix
left a comment
Collaborator
There was a problem hiding this comment.
just one minor thing which could end-up annoying when testing with -O1 and above, otherwise seems reasonable to me.
aktemur
force-pushed
the
users/aktemur/cluster-111
branch
from
October 6, 2026 13:23
621e132 to
2aad83f
Compare
The function 'amdgpu_used_lanes_count' in amdgpu-tdep.c and the function 'lane_workgroup_pos' in amd-dbgapi-target.c both compute partial workgroup sizes the same way. Extract the common code into a function named 'partial_workgroup_sizes' and reuse. This is a refactoring with no behavioral change.
Starting with gfx1250, workgroups may be organized into clusters, giving a workitem -> wave -> workgroup -> cluster -> grid hierarchy. Handle clusters by taking them into account when calculating workitem/lane coordinates, when showing wave target ids, and in the "info dispatches" command. Bug: AIROCGDB-77
aktemur
force-pushed
the
users/aktemur/cluster-111
branch
from
October 6, 2026 14:58
2aad83f to
a6bc758
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as PR #206, except that it uses the alternative dbgapi in PR ROCm/rocm-systems#10241.