Impl adam_w #2957
Merged
Impl adam_w #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
restarted the CI, @et16kr Please resolve the merge conflict. |
CAHEK7
requested changes
Jun 7, 2024
driver/adam_driver.hpp
Outdated
Comment on lines
238
to
239
| template <typename Tgpu, typename Tref, bool adamw, bool is_amp, typename Tgrad> | ||
| int AdamDriver<Tgpu, Tref, adamw, is_amp, Tgrad>::ParseCmdLineArgs(int argc, char* argv[]) |
There was a problem hiding this comment.
I missed a previous PR, but since a variable has been added here, I would ask is it necessary having all those variables as a template parameters?
At least is_amp and adamw should be runtime parameters to avoid code bloating and long compilation time.
CAHEK7
approved these changes
Jun 11, 2024
junliume
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adam float16
adam float32
amp adam (parameter float32, gradient float16)