-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Convert MIOpenDriver tests into shell script #2878
base: develop
Are you sure you want to change the base?
Conversation
|
Adding @atamazov , this looks like adding a functionality which will eventually replace/convert an existing one, I would suggest moving forward if no objections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately does not comply #1843 (2) and other things. I recommend implementing these tests just like we do other tests (but set normal environment and then exec MIOpenDriver with necessary command-line arguments instead of instantiating and using test classes from the ./test directory).
Hi @atamazov, thanks for the input. Unlike converting other cTests to gTest by implementing test classes and pack them into a single binary as this PR below, what the script does is to call MIOpenDriver binary with arguments like what you commented. The shell script has dependency on MIOpenDriver binary and also needs to have environment variables set. The reason is
Thanks |
What I am proposing is implementing the minimum test classes and calling MIOpenDriver from within the test, just like the script does. The advantage is that the test can work standalone -- it can check the GPU type, XNACK feature etc. But of course is will require the driver to exist, i.e. there is a dependence. |
Thanks for the comment. This script can indeed detect/check GPU type at runtime as below we can check other features too if they are relevant to MIOpenDriver tests. Line 86 in aaaf0be
This design offers a quick solution and hopefully same logic/coveratge as current MIOpenDriver tests to be part of the test package along with the stand alone gTest binary, miopen_gtest. We can do it with a class as proposed in another implementation/PR. FYI, this script does run by itself (given the presence of MIOpenDriver) if this makes sense. Thanks |
Creating a gTest to run MIOpenDriver is probably a better way than shell script. Will close this PR and create a new one for new implementation. |
I guess it can be closed, since #2984 has been merged. |
The shell script has dependency on the binary, MIOpenDriver