Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CK-based 2d/3d convolution solvers to support nchw/ncdhw layout #2429

Merged
merged 125 commits into from
Feb 8, 2024
Merged

Update CK-based 2d/3d convolution solvers to support nchw/ncdhw layout #2429

merged 125 commits into from
Feb 8, 2024

Commits on Oct 2, 2023

  1. WIP: updating 3d solver to support ncdhw layout

    @amberhassaan
    amberhassaan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7c7293e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. WIP: finished code structure for forward conv with layout transformat… 

    …ions
    @amberhassaan
    amberhassaan committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6927fac View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. WIP: forward 3d conv working

    @amberhassaan
    amberhassaan committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    fb05334 View commit details
    Browse the repository at this point in the history

  2. WIP: enable layout transform for Bwd, Weights and 2D NCHW layout as w… 

    …ell (Fwd, Bwd, Weights).
    @amberhassaan
    amberhassaan committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    eb48981 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9dae7fe View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Bwd and WrW tests working. 2D fwd case also working with NCHW layout

    @amberhassaan
    amberhassaan committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    a81b0bc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    3082342 View commit details
    Browse the repository at this point in the history

  3. formatting fixes

    @amberhassaan
    amberhassaan committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1062bd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. fix build. Do some cleanup

    @amberhassaan
    amberhassaan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8fd8275 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7a8dbab View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    ce9f023 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. resolve conflicts and address errors

    @amberhassaan
    amberhassaan committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    d9aec20 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ceb6c4a View commit details
    Browse the repository at this point in the history

  2. fix formatting

    @amberhassaan
    amberhassaan committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1241dd3 View commit details
    Browse the repository at this point in the history

  3. fix fin hash

    @amberhassaan
    amberhassaan committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9a6c1d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. WiP: redesign code

    @amberhassaan
    amberhassaan committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4f40720 View commit details
    Browse the repository at this point in the history

  2. WIP: new design compiles

    @amberhassaan
    amberhassaan committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0135bd1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. WIP: debugging the new design

    @amberhassaan
    amberhassaan committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8c08fbb View commit details
    Browse the repository at this point in the history

  2. clean up and formatting

    @amberhassaan
    amberhassaan committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    82f8d13 View commit details
    Browse the repository at this point in the history

  3. use static assert for alignment 

    Co-authored-by: Alex Eremin <[email protected]>
    @amberhassaan @CAHEK7
    amberhassaan and CAHEK7 authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    58cc9fb View commit details
    Browse the repository at this point in the history

  4. replace move to enable RVO. 

    Co-authored-by: Alex Eremin <[email protected]>
    @amberhassaan @CAHEK7
    amberhassaan and CAHEK7 authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    aa94868 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Merge pull request #2461 from ROCmSoftwarePlatform/amber/layout-conv-… 

    …reorg

NCHW convolution with layout transformation: Redesign and simplify
    @amberhassaan
    amberhassaan authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d797701 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    fdd597b View commit details
    Browse the repository at this point in the history

  2. fix build

    @amberhassaan
    amberhassaan committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    fe69c64 View commit details
    Browse the repository at this point in the history

  3. add checks for non-packed tensors with nchw layout

    @amberhassaan
    amberhassaan committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f515a74 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. fix bug with passing strides when using default layout

    @amberhassaan
    amberhassaan committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    b93be94 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    c217f9e View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. address review comments

    @amberhassaan
    amberhassaan committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    c76c086 View commit details
    Browse the repository at this point in the history

  2. fix hip-tidy failure

    @amberhassaan
    amberhassaan committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    9c5e6c7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into amber/layout-xform-conv

    @amberhassaan
    amberhassaan authored Oct 29, 2023
    Configuration menu
    Copy the full SHA
    bdb8e28 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge branch 'develop' into amber/layout-xform-conv

    @amberhassaan
    amberhassaan authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3c180ed View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. added checks on workspace params

    @amberhassaan
    amberhassaan committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    5d9d7fc View commit details
    Browse the repository at this point in the history

  2. add a method to solver to get workspace size

    @amberhassaan
    amberhassaan committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    392a48c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    90d28f8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'amber/add-workspace-check' into amber/layout-xform-conv

    @amberhassaan
    amberhassaan committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a3acc97 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. WIP: debugging a workspace issue

    @amberhassaan
    amberhassaan committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f7c5fea View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. addressed review comments

    @amberhassaan
    amberhassaan committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    75e18bb View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Merge remote-tracking branch 'origin/develop' into amber/add-workspac… 

    …e-check
    @amberhassaan
    amberhassaan committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9859d97 View commit details
    Browse the repository at this point in the history

  2. fix release build warning

    @amberhassaan
    amberhassaan committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9bb0750 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. WIP: workspace abstraction

    @amberhassaan
    amberhassaan committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    675b6a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. added an abstraction for workspace

    @amberhassaan
    amberhassaan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4b33079 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into amber/add-workspace-check

    @amberhassaan
    amberhassaan authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    6b12bcf View commit details
    Browse the repository at this point in the history

  3. fix a check

    @amberhassaan
    amberhassaan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    cdb9325 View commit details
    Browse the repository at this point in the history

  4. fix format

    @amberhassaan
    amberhassaan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    71f709b View commit details
    Browse the repository at this point in the history

  5. missed some instances

    @amberhassaan
    amberhassaan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ae5d50e View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/develop' into amber/workspace-ab… 

    …straction
    @amberhassaan
    amberhassaan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    02bf9d0 View commit details
    Browse the repository at this point in the history

  7. bring back the workspace round up logic

    @amberhassaan
    amberhassaan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    83d622b View commit details
    Browse the repository at this point in the history

  8. formatting

    @amberhassaan
    amberhassaan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4bd4253 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. fix hip tidy issues. add more checks

    @amberhassaan
    amberhassaan committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    6eef5fe View commit details
    Browse the repository at this point in the history

  2. fix a bug with zeroing out rnn workspace

    @amberhassaan
    amberhassaan committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f22aa2d View commit details
    Browse the repository at this point in the history

  3. fix hip-tidy error

    @amberhassaan
    amberhassaan committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d6ae39f View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Merge branch 'amber/add-workspace-check' into amber/workspace-abstrac… 

    …tion
    @amberhassaan
    amberhassaan committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    385d816 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into amber/workspace-ab… 

    …straction
    @amberhassaan
    amberhassaan committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    815b73a View commit details
    Browse the repository at this point in the history

  3. address review comments

    @amberhassaan
    amberhassaan committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    98ec151 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Remove a check that was missed for packed tensors (#2495)

    @amberhassaan
    amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d99f076 View commit details
    Browse the repository at this point in the history

  2. Fix builds with rocBLAS that does not support F8 (#2480) 

    * fix-build-old-rocblas-no-ck(01) Fix builds with rocBLAS that does not support F8

* fix-build-old-rocblas-no-ck(02) CK BN bugfixes. Fixes for builds without CK.

* fix-build-old-rocblas-no-ck(03) Update fin up to the most recent commit in develop

* fix-build-old-rocblas-no-ck(06) Resolve review comment
    @atamazov @amberhassaan
    atamazov authored and amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    445e3ae View commit details
    Browse the repository at this point in the history

  3. [Workaround] Issue 2496 - disabling the unit test case in wrw solver (#… 

    …2497)
    @carlushuang @amberhassaan
    carlushuang authored and amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c0a13fd View commit details
    Browse the repository at this point in the history

  4. [NFC] Replace miopen::ProblemDescription with conv::ProblemDescriptio… 

    …n, part 4 (#2410)
    @averinevg @amberhassaan
    averinevg authored and amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    840d0be View commit details
    Browse the repository at this point in the history

  5. Bump rocm-docs-core from 0.26.0 to 0.27.0 in /docs/.sphinx (#2501) 

    Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.26.0 to 0.27.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.26.0...v0.27.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot @amberhassaan
    dependabot[bot] authored and amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2185bed View commit details
    Browse the repository at this point in the history

  6. WIP: added abort for debugging

    @amberhassaan
    amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9b8b355 View commit details
    Browse the repository at this point in the history

  7. Update the SyncDB tests to use multi-threading (#2407)

    @JehandadKhan @amberhassaan
    JehandadKhan authored and amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5b8b026 View commit details
    Browse the repository at this point in the history

  8. Workaround for issue #2492 - disable ConvBinWinoRxS when granularity … 

    …loss is huge (#2507)

* workaround_issue_2492(01) Disable ConvBinWinoRxS when granularity loss is > 0.995 (performance drops 200 times)

* workaround_issue_2492(02) Allow disabing the W/A by setting MIOPEN_DEBUG_WORKAROUND_ISSUE_2493=0 in the env.
    @atamazov @amberhassaan
    atamazov authored and amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3cfd534 View commit details
    Browse the repository at this point in the history

  9. addressed review comments

    @amberhassaan
    amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0d023ed View commit details
    Browse the repository at this point in the history

  10. Fix build after resolving conflicts

    @amberhassaan
    amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    861e450 View commit details
    Browse the repository at this point in the history

  11. workaround the find api issue #2500

    @amberhassaan
    amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0f308f1 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    dc5fe1e View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Merge remote-tracking branch 'origin/amber/workspace-abstraction' int… 

    …o amber/layout-xform-conv
    @amberhassaan
    amberhassaan committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b4b91a9 View commit details
    Browse the repository at this point in the history

  2. fix build and use workspace abstraction

    @amberhassaan
    amberhassaan committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    639c468 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    9361596 View commit details
    Browse the repository at this point in the history

  4. fix formatting

    @amberhassaan
    amberhassaan committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    2237f2c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. add a row of values for pads and strides that are not 1

    @amberhassaan
    amberhassaan committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ce7b0f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Merge branch 'develop' into amber/conv3d-bwd-wrw-tests

    @junliume
    junliume authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    85a158c View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. wip: test against cpu ref

    @amberhassaan
    amberhassaan committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1399b97 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into amber/conv3d-bwd-w… 

    …rw-tests
    @amberhassaan
    amberhassaan committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ac6640b View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    60ddb34 View commit details
    Browse the repository at this point in the history

  2. fix build post merge

    @amberhassaan
    amberhassaan committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6b6693d View commit details
    Browse the repository at this point in the history

  3. fix format. add some debug prints

    @amberhassaan
    amberhassaan committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d2a8cfe View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. add debug prints

    @amberhassaan
    amberhassaan committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    fa5c4e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. bug fix for bwd pass

    @amberhassaan
    amberhassaan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    da689f8 View commit details
    Browse the repository at this point in the history

  2. fix build. Syntax change to invoke conversion operator

    @amberhassaan
    amberhassaan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    43aae4c View commit details
    Browse the repository at this point in the history

  3. fix format

    @amberhassaan
    amberhassaan committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    19c18e5 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. fixed another in/out bug

    @amberhassaan
    amberhassaan committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    61afb9e View commit details
    Browse the repository at this point in the history

  2. add workspace size to conv solution

    @amberhassaan
    amberhassaan committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    aa96ed3 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. WIP: bug fixed but needs clean up

    @amberhassaan
    amberhassaan committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f8976bf View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into amber/conv3d-bwd-w… 

    …rw-tests
    @amberhassaan
    amberhassaan committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c4da269 View commit details
    Browse the repository at this point in the history

  3. cleanup and formatting

    @amberhassaan
    amberhassaan committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    06e0dc7 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge branch 'develop' into amber/conv3d-bwd-wrw-tests

    @amberhassaan
    amberhassaan authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    3bf0988 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/amber/conv3d-bwd-wrw-tests' into… 

    … amber/layout-xform-conv
    @amberhassaan
    amberhassaan committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b67acb3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into amber/layout-xform-conv

    @junliume
    junliume authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c80355b View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. WIP: still debugging wrw case

    @amberhassaan
    amberhassaan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8fb21bf View commit details
    Browse the repository at this point in the history

  2. fixed bug in wrw: zero out workspace buffer before calling CK kernel

    @amberhassaan
    amberhassaan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    0b31b2d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    65a0e64 View commit details
    Browse the repository at this point in the history

  4. fix formatting

    @amberhassaan
    amberhassaan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    641cf69 View commit details
    Browse the repository at this point in the history

  5. bwd swap bug fix

    @amberhassaan
    amberhassaan committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    58e9f09 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. fixed warning

    @amberhassaan
    amberhassaan committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    7a2ab4a View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d5eab9e View commit details
    Browse the repository at this point in the history

  2. new test for 2d bwd conv

    @amberhassaan
    amberhassaan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    aa209a2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into amber/layout-xform-conv

    @junliume
    junliume authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    094abe5 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. WIP: debugging

    @amberhassaan
    amberhassaan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1672c15 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    10254b5 View commit details
    Browse the repository at this point in the history

  3. fix fin commit hash

    @amberhassaan
    amberhassaan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    276449f View commit details
    Browse the repository at this point in the history

  4. fix build after merging latest develop

    @amberhassaan
    amberhassaan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    36dac04 View commit details
    Browse the repository at this point in the history

  5. choose better name

    @amberhassaan
    amberhassaan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c762821 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2a7974a View commit details
    Browse the repository at this point in the history

  7. fix formatting

    @amberhassaan
    amberhassaan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6185b7c View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. bug fixes for bwd and wrw gtests

    @amberhassaan
    amberhassaan committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    eefb1ac View commit details
    Browse the repository at this point in the history

  2. remove nchw support from non-grouped 2d convolution solvers

    @amberhassaan
    amberhassaan committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    0a1e4dc View commit details
    Browse the repository at this point in the history

  3. fix build for NO_CK flag

    @amberhassaan
    amberhassaan committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7a5ad48 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'develop' into amber/layout-xform-conv

    @amberhassaan
    amberhassaan authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    435f3a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. add initializing transpose operation for convolution output. This is … 

    …needed for cases where convolution does not update all of the output indices, e.g., strided convolutions
    @amberhassaan
    amberhassaan committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    80e1a4a View commit details
    Browse the repository at this point in the history

  2. fix formatting

    @amberhassaan
    amberhassaan committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5628fa4 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge branch 'develop' into amber/layout-xform-conv

    @amberhassaan
    amberhassaan authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    3c7a44d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4f6eab1 View commit details
    Browse the repository at this point in the history

  2. code cleanup

    @amberhassaan
    amberhassaan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    656ed63 View commit details
    Browse the repository at this point in the history

  3. fix formatting

    @amberhassaan
    amberhassaan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4ce0c77 View commit details
    Browse the repository at this point in the history

  4. enable nchw convolution gtests. Enable 2d fwd grouped conv

    @amberhassaan
    amberhassaan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    01aebb7 View commit details
    Browse the repository at this point in the history

  5. fix fin hash

    @amberhassaan
    amberhassaan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    368ccca View commit details
    Browse the repository at this point in the history

  6. enable NCHW for 2D conv solvers as well. Fix bug in test fixture clas… 

    …s related to workspace size
    @amberhassaan
    amberhassaan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e86e163 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5c4cf59 View commit details
    Browse the repository at this point in the history

  2. address review comments

    @amberhassaan
    amberhassaan committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8b9b4a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. align total size to 256 byte boundary

    @amberhassaan
    amberhassaan committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f0629b6 View commit details
    Browse the repository at this point in the history

  2. fix running time accumulation logic. 

    Co-authored-by: Artem Tamazov <[email protected]>
    @amberhassaan @atamazov
    amberhassaan and atamazov authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a5767da View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into amber/layout-xform… 

    …-conv
    @amberhassaan
    amberhassaan committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ff01caf View commit details
    Browse the repository at this point in the history

  4. fix build after merge from develop

    @amberhassaan
    amberhassaan committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    83d9fd2 View commit details
    Browse the repository at this point in the history

  5. fix and simplify padding logic

    @amberhassaan
    amberhassaan committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9088ac7 View commit details
    Browse the repository at this point in the history