[NFC] Replace miopen::ProblemDescription with conv::ProblemDescription, part 2 #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nCompat + cleanup
…th ProblemDescriptionCompat for SQLitePerfDb and test_sqlite_perfdb
…problem_description_part_2
…problem_description_part_2
…problem_description_part_2
averinevg
commented
Jun 1, 2023
…problem_description_part_2
DrizztDoUrden
approved these changes
Jun 12, 2023
atamazov
approved these changes
Jun 16, 2023
| @@ -95,7 +95,7 @@ static Random& Rnd() | |||
|
|
|||
| struct ProblemData : SQLiteSerializable<ProblemData> | |||
| { | |||
| ProblemDescription prob; | |||
| ProblemDescriptionCompatTemporary prob; | |||
There was a problem hiding this comment.
[Future] This leftover must be removed with high urgency.
|
Let me run my set of performance tests before merging |
…problem_description_part_2
|
Today we discussed this PR with @atamazov. All validation tests passed, so we can merge the PR. Estimated time for performance test results - the day after tomorrow |
junliume
approved these changes
Jun 20, 2023
🌀 Performance testing resultsPreconditions:
Tested modes:
Bottom line: 🟢 No performance or correctness regressions. Logs & csv files available upon request. |
averinevg
deleted the
ea_replace_problem_description_with_conv_problem_description_part_2
branch
atamazov
reviewed
Oct 23, 2023
Comment on lines
-107
to
-109
| : ProblemDescription(dir == conv::Direction::Forward | ||
| ? conv::ProblemDescription{in, weights, out, conv, dir, bias_} | ||
| : conv::ProblemDescription{out, weights, in, conv, dir, bias_}) |
There was a problem hiding this comment.
After this PR, we do not swap xDesc and yDesc in the ProblemDescription, i.e. GetIn() always returns xDesc.
There was a problem hiding this comment.
Oh no, we still swap descriptors.
/cc @averinevg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
ProblemDescriptiondata fields have been removedmlo_construct_direct2D_fusionhas been replaced withProblemDescriptionand removedProblemDescriptionCompatTemporaryhas been created for use in legacy codeBlocker: ROCm/MIFin#83
See #266