Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XNACK+] Need to disable a few tests #2866

Open
junliume opened this issue Apr 2, 2024 · 3 comments
Open

[XNACK+] Need to disable a few tests #2866

junliume opened this issue Apr 2, 2024 · 3 comments
Assignees
@junliume

Comments

@junliume
Copy link
Collaborator

junliume commented Apr 2, 2024

@atamazov could you help? We need to disable these following tests when XNACK is positive.

we can sort of

    const auto target = conv_ctx.GetStream().GetTargetProperties();
    if(target.Xnack() && *target.Xnack())
        return false;

#2865

+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|                                                                                                              FAILED TESTCASES                                                                                                              |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+
|                                                                                                          Test Case                                                                                                           | Test Result |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+
| CBAFind2InferSolverTest/ConvBiasActivFind2InferTestFloatFusionFind.ConvBiasActivFind2Float_testFind/(3, (N: 1 C:64 H:56 W:56 k: 64 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) |    FAILED   |
| CBAFind2InferSolverTest/ConvBiasActivFind2InferTestFloatFusionFind.ConvBiasActivFind2Float_testFind/(3, (N: 1 C:64 H:56 W:56 k: 64 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0) |    FAILED   |
|                   CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:1024 H:14 W:14 k: 2048 y:1 x:1 pad_y:0 pad_x:0 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                   |    FAILED   |
|                   CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:1024 H:14 W:14 k: 256 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                   CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:1024 H:14 W:14 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:128 H:28 W:28 k: 128 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:128 H:28 W:28 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:128 H:56 W:56 k: 128 y:3 x:3 pad_y:1 pad_x:1 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:2048 H:7 W:7 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
|                   CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:14 W:14 k: 1024 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:14 W:14 k: 256 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:28 W:28 k: 256 y:3 x:3 pad_y:1 pad_x:1 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:56 W:56 k: 128 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:56 W:56 k: 512 y:1 x:1 pad_y:0 pad_x:0 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:256 H:56 W:56 k: 64 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:3 H:224 W:224 k: 64 y:7 x:7 pad_y:3 pad_x:3 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:14 W:14 k: 512 y:3 x:3 pad_y:1 pad_x:1 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                   CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:28 W:28 k: 1024 y:1 x:1 pad_y:0 pad_x:0 stride_y:2 stride_x:2 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:28 W:28 k: 128 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:28 W:28 k: 256 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                    |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:7 W:7 k: 2048 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
|                     CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:512 H:7 W:7 k: 512 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
|                    CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:64 H:56 W:56 k: 256 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
|                     CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:64 H:56 W:56 k: 64 y:1 x:1 pad_y:0 pad_x:0 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
|                     CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall/(3, (N: 64 C:64 H:56 W:56 k: 64 y:3 x:3 pad_y:1 pad_x:1 stride_y:1 stride_x:1 dilation_y:1 dilation_x:1 conv_mode:0 ), 0)                     |    FAILED   |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+
@junliume junliume self-assigned this Apr 2, 2024
@JehandadKhan
Copy link
Collaborator

JehandadKhan commented Apr 2, 2024 via email

@atamazov
Copy link
Contributor

atamazov commented Apr 2, 2024

@JehandadKhan @cderb @junliume

It seems like some (or all) of the Fused solvers become inapplicable for the tested configs when XNACK is enabled on target.

I see two options for CBAInferSolverTest/FusionSetArgTestFloat.TestSetArgApiCall tests

  • (1) When XNACK is enabled, skip the test.
  • (2) When XNACK is enabled, use the narrowed list of configs, i.e. those that remain applicable for XNACK-enabled targets instead of

    MIOpen/test/gtest/conv_test_base.hpp

    Line 85 in c55cc82

    inline std::vector<ConvTestCaseBase> GetNetwork1()

Ditto WRT CBAFind2InferSolverTest/ConvBiasActivFind2InferTestFloatFusionFind.ConvBiasActivFind2Float_testFind except that the list of configs-under-the-test is defined at

MIOpen/test/gtest/conv_test_base.hpp

Line 75 in c55cc82

inline std::vector<ConvTestCaseBase> GetNetworkForFusionCompileStepTest()

I would prefer option (2), if possible, but I am not sure if XNACK targets are important for us and if we have any applicable fused solvers. The final decision is up to the respective engineer.

Please let me know if you need more assistance.

@JehandadKhan
Copy link
Collaborator

@cderb Please see this thread wrt your PR #2870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junliume junliume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JehandadKhan @junliume @atamazov