[HIPIFY][clang][compatibility][fix] clang 21.0.0git compatibility fix#1974
Merged
emankov merged 1 commit intoROCm:amd-developfrom May 29, 2025
emankov:HIPIFY
Merged
[HIPIFY][clang][compatibility][fix] clang 21.0.0git compatibility fix#1974emankov merged 1 commit intoROCm:amd-developfrom emankov:HIPIFY
21.0.0git compatibility fix#1974emankov merged 1 commit intoROCm:amd-developfrom
emankov:HIPIFY
Conversation
[Root Cause] + [LLVM][#139584](https://github.com/llvm/llvm-project/pull/139584)[clang] Remove intrusive reference count from `DiagnosticOptions` [IMP] + `LLVM < 21` is also supported, but `LLVM 21` should be newer than [671cd5acb49f9fae274f66cd71464d4afed914e3](llvm/llvm-project@671cd5a) (2025-05-20) to build `hipify-clang` correctly [Note] + Unfortunately, the class `DiagnosticsEngine` has assignment operator and copy ctor both marked as `delete`, thus the compatibility patch can't be implemented as a separate function in the `llcompat` namespace
emankov
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Root Cause]
DiagnosticOptions[IMP]
LLVM < 21is also supported, butLLVM 21should be newer than 671cd5acb49f9fae274f66cd71464d4afed914e3 (2025-05-20) to buildhipify-clangcorrectly[Note]
DiagnosticsEnginehas assignment operator and copy ctor both marked asdelete, thus the compatibility patch can't be implemented as a separate function in thellcompatnamespace