Repository navigation
[Fix]: mla_decode test aborts whole collection on aiter API drift - #840
Merged
Merged
Conversation
importorskip only covers a missing aiter module; the top-level symbol import still hard-fails when the attention API drifts (e.g. hk_mla_decode_fwd renamed), raising ImportError during collection and taking down the entire test session (exit 2). Wrap it in try/except and skip the module instead so the mismatch degrades to a clean per-module skip.
coderfeli
approved these changes
Jul 13, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importorskip only covers a missing aiter module; the top-level symbol import still hard-fails when the attention API drifts (e.g. hk_mla_decode_fwd renamed), raising ImportError during collection and taking down the entire test session (exit 2). Wrap it in try/except and skip the module instead so the mismatch degrades to a clean per-module skip.