Repository navigation
fix slice return type on coord_tensor - #707
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes fly.slice return-type inference for !fly.coord_tensor so that slicing a coordinate tensor with a linear LayoutAttr also updates the tensor’s base (not just its layout), aligning the inferred type with the actual slice offset semantics.
Changes:
- Update
SliceOp::inferReturnTypesto add the computed slice offset intoCoordTensorType’sbasewhen slicing a linearLayoutAttr. - Keep existing behavior for composed layouts (where the slice offset is represented in the composed layout’s offset).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sjfeng1999
approved these changes
Jun 22, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Slicing on Coordinate Tensor should change the base of the return type as well, but original implementation didn't change the base, this PR fix it.
Technical Details
Test Plan
Test Result
Submission Checklist