Skip to content

fix(run_benchmark): report base norm bandwidth, not the last variant (layernorm 1.69 → 5.6 TB/s) #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coderfeli merged 1 commit into from
Jun 6, 2026
Merged

fix(run_benchmark): report base norm bandwidth, not the last variant (layernorm 1.69 → 5.6 TB/s) #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions scripts/run_benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,11 +454,14 @@ if tbps is None or tflops is None:
tflops = float(m.group(1))
tbps = float(m.group(2))

# Softmax/Norm-style: "Kernel avg time: X ms" + "Bandwidth: Y GB/s"
# Softmax/Norm-style: "Kernel avg time: X ms" + "Bandwidth: Y GB/s".
# Use the FIRST match: the base op (softmax/layernorm/rmsnorm) is benchmarked
# first, so any later "Bandwidth:" lines come from fused/quant variants printed
# by the same test (e.g. test_layernorm.py also runs fused_add/dynamicquant/
# smoothquant). Taking the last match reported the slow scalar smoothquant path
# as "layernorm" (~1.69 vs the real ~5.6 TB/s base).
if tbps is None:
m_bw = None
for m_bw in re.finditer(r"Bandwidth:\s*([0-9.]+)\s*GB/s", txt):
pass
m_bw = next(re.finditer(r"Bandwidth:\s*([0-9.]+)\s*GB/s", txt), None)
if m_bw:
tbps = float(m_bw.group(1)) / 1000.0

Expand Down
Loading