Repository navigation
fix(moe): restore TP MoE num_local_tokens - #2905
Merged
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every eligible PR before approval:
Heavy model tests:
|
JiaoliangYu
marked this pull request as ready for review
November 3, 2026 03:06
valar-cop
reviewed
Nov 3, 2026
valar-cop
left a comment
There was a problem hiding this comment.
some changes needed..
pure-TP decode perf with aiter#7294 vs main, and gsm8k for a padded cudagraph bucket?
ci green.
JiaoliangYu
marked this pull request as draft
November 3, 2026 10:06
JiaoliangYu
marked this pull request as ready for review
November 3, 2026 13:09
valar-cop
reviewed
Nov 3, 2026
valar-cop
left a comment
There was a problem hiding this comment.
some changes needed..
pure-TP decode perf with aiter#7294 vs main, and gsm8k for a padded cudagraph bucket on the pure-TP path?
ci green.
Open
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2776 discarded
scheduled_tokens_gpuwheneveruse_epwas false, so pure TP lost the real-token count introduced by #2725. Restore the count for ungathered TP rows; the existing MoE methods forward it to AITER asnum_local_tokens. DP/PCP-gathered rows still receiveNone, andpass_scheduled_tokens_gpurejects row subsets that do not match the current pass.Run the routed-row regression tests on CPU under AITER/Triton stubs. During this test module's import, bypass CUDA custom-op registration so fake enum defaults do not enter schema inference or leave stub kernels in PyTorch's process-wide registry. The TP/EP regression exercises the production
_run_expertsandpass_scheduled_tokens_gputogether: a complete local pass receives its count, while gathered rows and row subsets do not.Dependency and backend scope: ROCm/aiter#7294 is still unmerged. Restoring
num_local_tokenson older AITER with padded CUDA-graph shapes can reintroduce its atomic GEMM2 padding-sentinel regression. The stage2 paths covered by that dependency are FlyDSL, FlyDSL-v2, and native-MXFP4. The current target configuration does not use Opus GEMM2. Keep this PR in draft while #7294 is unmerged and the requested pure-TP decode performance comparison remains pending.Validation:
tests/test_pass_scheduled_tokens.pyandtests/model_ops/test_dp_gather_routed_rows.pycompleted with 10 passed and no skips.--target-version py312), Ruff, andgit diff --checkpassed for the changed file.