Repository navigation
[PCP] Fewer V4 prefill gathers and fix PCP+TBO accuracy #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,439
−496
Merged
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
16e4f7b
[PCP] Fewer prefill collectives per layer, no reindex readback
yitingw1 dc90ce2
[PCP] DSpark: project context KV on each rank's own rows
yitingw1 7017852
[PCP] Grouped gather: fall back off aiter's 2/4/8 ranks; check row co…
yitingw1 222feeb
fix(config): key the compile cache on the KV cache dtype
yitingw1 b491763
[PCP] TBO: hold comm-stream gather outputs until the compute stream r…
yitingw1 6b49222
[PCP] TBO: run the PCP comm phases through tbo_on_comm
yitingw1 9d1db12
Merge remote-tracking branch 'origin/main' into yitingw1/pcp_opt
yitingw1 e182354
[PCP] TBO: hold every comm-stream output; one wire format for grouped…
yitingw1 e8ff821
test(tbo): stub aiter's communication_op in the TP all-reduce test
yitingw1 7e2920f
[PCP] Grouped gather: drop the 6-rank special case, rely on aiter
yitingw1 fd0893d
test(h2d): give the PCP reindex test the host prefill indptr
yitingw1 319ffe1
test(h2d): bring the V4 indexer publication GPU test up to date
yitingw1 fd912b7
DSV4 PCP: assert host and GPU paged-prefill indptrs agree in length
yitingw1 c889ff9
Merge branch 'main' into yitingw1/pcp_opt
yitingw1 65fed29
Merge remote-tracking branch 'origin/main' into yitingw1/pcp_opt
yitingw1 c9b9de7
DSV4 PCP: stage only this rank's paged-prefill rows on main's stage/f…
yitingw1 aee343c
Drop the duplicate kv_cache_dtype compile-hash factor left by the mai…
yitingw1 1e582ae
Merge remote-tracking branch 'origin/main' into yitingw1/pcp_opt
yitingw1 5e4e8bb
fix(spec_decode): check target_pcp_split before PCP world size in pcp…
yitingw1 c5b86da
fix(v4 attn): make _apply_pcp_reindex take cu_q / block_tables explic…
yitingw1 4149e4e
Merge origin/main into yitingw1/pcp_opt
yitingw1 32bf41e
test(comm-fused-moe): ids travel as int32, drop the no-op view
yitingw1 f7d83ab
dspark(v4.1): drop the unreachable PCP branch from write_context_kv
yitingw1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.