Repository navigation
[MiniMax-M3.1] Add TP4 P/D Mooncake Store benchmarks and NVFP4 recipe - #2750
Draft
MengqingCao wants to merge 20 commits into
Draft
MengqingCao wants to merge 20 commits into
MengqingCao wants to merge 20 commits into
Conversation
Contributor
🏷️ CI GuideRuns automatically on every eligible PR before approval:
Heavy model tests:
|
This was referenced Oct 27, 2026
Group complete cached-prefill requests under a per-layer dense K/V budget. Carry owned CPU lengths through target, Eagle and TBO metadata, and reserve the largest local workspace before sizing persistent KV pools. Expose --gqa-prefill-kv-workspace-mb and cover grouping, dispatch and memory accounting with focused regression tests. (cherry picked from commit 2ab9b9c)
Run full GSM8K 20-shot evaluation at concurrency 32 using amd/MiniMax-M3.1-Flash-Quark-MXFP4. Use one MI355X node with TP4 prefill and TP4 decode over Mooncake RDMA, and reserve 8192 MiB of dense cached-prefill workspace per rank on both roles.
Port the Store compatibility, complete PAGE codec, and codec namespace from 0021a4a. Reuse the current target and draft region exports for M3.1 TP4 P/D. Include index-cache and draft planes in regression coverage and preserve the dense codec path.
Fingerprint both format switches and cover NVFP4 payload/index-scale regions in CPU transfer tests.
Use recipe #2747 settings and AgentX 1.0.12, retaining 1 TiB Mooncake Store, RDMA P/D transfer, and the 30-second trace window. Resolve model-specific images and served model names.
This reverts commit 2142d54.
MengqingCao
force-pushed
the
mengqing/m31-flash-pd-workspace8g
branch
from
October 28, 2026 03:59
e73246e to
21224a2
Compare
This was referenced Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax-M3.1-Flash P/D with Mooncake Store needs to preserve the complete M3 PAGE layout, including sparse index and draft regions. This PR adds that Store support and a TP4-prefill / TP4-decode recipe with accuracy, AgentX benchmark, timed P/D trace, and C32 chunked-transfer comparison cases.
The recipe adapts #2747 to eight MI355X GPUs and includes the runtime changes ported from #2686 and #2743–#2746. The branch is rebased onto
mainatebd5f84f3, including the chunked P/D protocol from #2425. The AgentX launcher conflicts are resolved using the upstream PyPI installer while retaining this recipe's version 1.0.12 and CLI defaults.Changes
enable_chunked_transferon the producer, with a matching unchanged C32 baseline. Add CPU-buffer coverage of incremental transfer for target NVFP4/scales, FP4 index/scales, draft FP8, cached-prefix skipping and final DSpark handoff.Experiment configuration
amd/MiniMax-M3.1-Flash-Quark-MXFP4agentx-harness==1.0.12,semianalysis_cc_traces_weka_062126enable_chunked_transferdiffersrocm/atom-dev:nightly_202610261558, branch mounted; matching ATOMesh router built from sourceThe dense cached-prefill workspace feature remains reverted; this sparse-attention recipe does not depend on it. Traces are stored under each job's shared
torch_traces/<worker>/rank_<tp>/directory. P/D throughput/GPU divides by all eight allocated GPUs.For chunked transfer, compare client/route-level TTFT and throughput. Decode queue/KV-wait timers start earlier with parallel P/D dispatch and can include prefill work. A prefill completing in one compute chunk offers limited compute/transfer overlap, and earlier destination reservation can increase decode KV pressure. The first comparison keeps the 32768-token budget fixed.
Validation
21224a248c282d8c19fc6c4ff9eeb596089cc744; base:ebd5f84f3a6af6a99d23f85e5c1107b238d1cdaf.pit2-p03-g12, 3600 seconds each. GPU results are pending.e73246e80completed C32, C48 and C64. Total throughput was 231,882.38 / 310,065.13 / 377,440.25 tok/s. C48/C64 each cancelled three requests at drain; C64 also reached a 300-second cancellation-confirmation timeout before exporting successfully. These are individual successful jobs, not a claim that the entire sweep succeeded.cc113529a. It predates the workspace revert and this rebase. Synthetic-acceptance performance runs do not establish GSM8K accuracy.