Skip to content

fix(qwen4_exp): load unscaled Quark MTP weights as BF16 - #2606

Merged
valarLip merged 1 commit into
mainfrom
lingzha/qwen38-fp4-mtp
Oct 26, 2026
Merged

valarLip merged 1 commit into
mainfrom
lingzha/qwen38-fp4-mtp

Conversation

@ZLkanyo009

Copy link
Copy Markdown
Contributor

Summary

  • Quark's exclude list on amd/Qwen3.8-Flash-Next-Quark-MXFP4 misses mtp.fc_embedding and mtp.layers.0.mlp.experts. The whole MTP head is BF16 and has no scale tensors, but ATOM still applies the MXFP4 spec and draft loading fails.
  • If the checkpoint index has no mtp.* scale tensors, resolve every mtp.* layer as excluded. A head that carries scales, or a checkpoint with no readable index, keeps the configured policy.

Test plan

  • TP1 server loads amd/Qwen3.8-Flash-Next-Quark-MXFP4 with --method mtp --num-speculative-tokens 3 and the draft weights come up.
  • One chat completion returns under forced acceptance length 2.32.
  • GSM8K strict/flexible match stays in line with the no-MTP Quark run.

Quark lists excluded modules one by one and misses mtp.fc_embedding and
mtp.layers.0.mlp.experts on amd/Qwen3.8-Flash-Next-Quark-MXFP4. The MTP
head is stored entirely in BF16, with no scale tensors, but ATOM still
applies the MXFP4 spec and the draft load fails.

When the checkpoint index shows no MTP scale tensors, treat every mtp.*
layer as excluded. A head that does carry scales, or a checkpoint with
no readable index, keeps the configured policy.
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 2606 --add-label <label>

@valarLip
valarLip merged commit 5fea029 into main Oct 26, 2026
2 of 4 checks passed
@valarLip
valarLip deleted the lingzha/qwen38-fp4-mtp branch October 26, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants