Skip to content

fix(build): only use v* tags for setuptools_scm version - #2393

Closed
yhl-amd wants to merge 1 commit into
mainfrom
fix/scm-describe-match-v-tags
Closed

yhl-amd wants to merge 1 commit into
mainfrom
fix/scm-describe-match-v-tags

Conversation

@yhl-amd

@yhl-amd yhl-amd commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Problem

Since the lmcache-v0.5.6.dev98-g05fc77a0-rocm-torch210 release tag was created (2026-09-24 09:50 UTC), it is the nearest tag reachable from main. setuptools_scm picks it via git describe and fails to parse it:

ValueError: Can't parse version from tag 'lmcache-v0.5.6.dev98-g05fc77a0-rocm-torch210'

As a result pip install -e . fails, breaking Pre Checkin "Run non-GPU unit tests" on main and all PRs based on recent main (e.g. https://github.com/ROCm/ATOM/actions/runs/35996699729/job/107623216735).

Fix

Add git_describe_command with --match "v[0-9]*" so only ATOM version tags (v0.1.6, v0.1.6-rc0, ...) are considered. The lmcache release/tag is kept as-is.

Verification

  • Without fix: python -m setuptools_scm → the ValueError above
  • With fix: python -m setuptools_scm → 0.1.7.dev28+g3a2df1d... (derived from v0.1.6)

🤖 Generated with Claude Code

The lmcache-v0.5.6.dev98-g05fc77a0-rocm-torch210 release tag is now the
nearest tag reachable from main, and setuptools_scm cannot parse it as a
PEP 440 version, so `pip install -e .` fails in the Pre Checkin CI.

Restrict git describe to tags matching v[0-9]* so non-ATOM release tags
are ignored while the ATOM version is still derived from vX.Y.Z tags.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 2393 --add-label <label>

@yhl-amd

yhl-amd commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #2395 together with the LMCache wheel workflow change, so both land with one review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant