Repository navigation
Conversation
The lmcache-v0.5.6.dev98-g05fc77a0-rocm-torch210 release tag is now the nearest tag reachable from main, and setuptools_scm cannot parse it as a PEP 440 version, so `pip install -e .` fails in the Pre Checkin CI. Restrict git describe to tags matching v[0-9]* so non-ATOM release tags are ignored while the ATOM version is still derived from vX.Y.Z tags. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
🏷️ CI GuideRuns automatically on every eligible PR before approval:
Heavy model tests:
|
Contributor
Author
|
Folded into #2395 together with the LMCache wheel workflow change, so both land with one review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the
lmcache-v0.5.6.dev98-g05fc77a0-rocm-torch210release tag was created (2026-09-24 09:50 UTC), it is the nearest tag reachable frommain. setuptools_scm picks it viagit describeand fails to parse it:As a result
pip install -e .fails, breaking Pre Checkin "Run non-GPU unit tests" onmainand all PRs based on recent main (e.g. https://github.com/ROCm/ATOM/actions/runs/35996699729/job/107623216735).Fix
Add
git_describe_commandwith--match "v[0-9]*"so only ATOM version tags (v0.1.6,v0.1.6-rc0, ...) are considered. The lmcache release/tag is kept as-is.Verification
python -m setuptools_scm→ the ValueError abovepython -m setuptools_scm→0.1.7.dev28+g3a2df1d...(derived fromv0.1.6)🤖 Generated with Claude Code