[ATOM][Bugfix] Disable flydsl_gather_kv_b_proj for GLM5.2 - #2221
Merged
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every eligible PR before approval:
Heavy model tests:
|
MengqingCao
force-pushed
the
mengqing/fix_flydsl_gather_kv_b_proj
branch
from
September 14, 2026 03:39
494542f to
40109af
Compare
…dels Signed-off-by: Mengqing Cao <cmq0113@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
MengqingCao
force-pushed
the
mengqing/fix_flydsl_gather_kv_b_proj
branch
from
September 14, 2026 03:56
40109af to
4551254
Compare
zhuyuhua-v
approved these changes
Sep 14, 2026
1 task
sajandhy
pushed a commit
to sajandhy/ATOM
that referenced
this pull request
Sep 17, 2026
…dels (ROCm#2221) Signed-off-by: Mengqing Cao <cmq0113@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Disable
flydsl_gather_kv_b_projfor the unsupported models, e.g., GLM-5.2. It is clearly described that theflydsl_gather_kv_b_projcould only support the model withqk_nope_head_dim == v_head_dim == 128, thus this pr disable it for GLM-5.2 in recipes and test cases.Test Plan
Test Result
Submission Checklist