Skip to content

[ATOM][Bugfix] Disable flydsl_gather_kv_b_proj for GLM5.2 - #2221

Merged
zhuyuhua-v merged 1 commit into
mainfrom
mengqing/fix_flydsl_gather_kv_b_proj
Sep 14, 2026
Merged

zhuyuhua-v merged 1 commit into
mainfrom
mengqing/fix_flydsl_gather_kv_b_proj

Conversation

@MengqingCao

@MengqingCao MengqingCao commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Disable flydsl_gather_kv_b_proj for the unsupported models, e.g., GLM-5.2. It is clearly described that the flydsl_gather_kv_b_proj could only support the model with qk_nope_head_dim == v_head_dim == 128, thus this pr disable it for GLM-5.2 in recipes and test cases.

Test Plan

Test Result

Submission Checklist

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 2221 --add-label <label>

@MengqingCao
MengqingCao force-pushed the mengqing/fix_flydsl_gather_kv_b_proj branch from 494542f to 40109af Compare September 14, 2026 03:39
…dels

Signed-off-by: Mengqing Cao <cmq0113@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@MengqingCao
MengqingCao force-pushed the mengqing/fix_flydsl_gather_kv_b_proj branch from 40109af to 4551254 Compare September 14, 2026 03:56
@MengqingCao MengqingCao changed the title [ATOM][Bugfix] Disable flydsl_gather_kv_b_proj for the unsupported models [ATOM][Bugfix] Disable flydsl_gather_kv_b_proj for GLM5.2 Sep 14, 2026
@zhuyuhua-v
zhuyuhua-v merged commit bf9b129 into main Sep 14, 2026
38 of 39 checks passed
@zhuyuhua-v
zhuyuhua-v deleted the mengqing/fix_flydsl_gather_kv_b_proj branch September 14, 2026 05:24
zhuyuhua-v pushed a commit that referenced this pull request Sep 14, 2026
sajandhy pushed a commit to sajandhy/ATOM that referenced this pull request Sep 17, 2026
…dels (ROCm#2221)

Signed-off-by: Mengqing Cao <cmq0113@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
sajandhy pushed a commit to sajandhy/ATOM that referenced this pull request Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants